Skip to content

Commit f523ad3

Browse files
h4x3rotabclaude
andcommitted
fix: nginx warnings and clarify build requirements
- Fixed OCSP stapling by using fullchain.pem - Fixed deprecated http2 directive syntax - Updated README to clarify build-image.sh usage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent dcdf151 commit f523ad3

2 files changed

Lines changed: 14 additions & 5 deletions

File tree

custom-domain/dstack-ingress/README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,16 +88,24 @@ Explanation of environment variables:
8888
If you prefer to build the image yourself:
8989

9090
1. Clone this repository
91-
2. Build the Docker image:
91+
2. Build the Docker image using the provided build script:
9292

9393
```bash
94-
docker build -t yourusername/dstack-ingress .
94+
./build-image.sh yourusername/dstack-ingress:tag
9595
```
9696

97+
**Important**: You must use the `build-image.sh` script to build the image. This script ensures reproducible builds with:
98+
- Specific buildkit version (v0.20.2)
99+
- Deterministic timestamps (`SOURCE_DATE_EPOCH=0`)
100+
- Package pinning for consistency
101+
- Git revision tracking
102+
103+
Direct `docker build` commands will not work properly due to the specialized build requirements.
104+
97105
3. Push to your registry (optional):
98106

99107
```bash
100-
docker push yourusername/dstack-ingress
108+
docker push yourusername/dstack-ingress:tag
101109
```
102110

103111
4. Update the docker-compose.yaml file with your image name and deploy

custom-domain/dstack-ingress/scripts/entrypoint.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ setup_py_env() {
1515
setup_nginx_conf() {
1616
cat <<EOF > /etc/nginx/conf.d/default.conf
1717
server {
18-
listen ${PORT} ssl http2;
18+
listen ${PORT} ssl;
19+
http2 on;
1920
server_name ${DOMAIN};
2021
2122
# SSL certificate configuration
@@ -37,7 +38,7 @@ server {
3738
# Enable OCSP stapling
3839
ssl_stapling on;
3940
ssl_stapling_verify on;
40-
ssl_trusted_certificate /etc/letsencrypt/live/${DOMAIN}/chain.pem;
41+
ssl_trusted_certificate /etc/letsencrypt/live/${DOMAIN}/fullchain.pem;
4142
resolver 8.8.8.8 8.8.4.4 valid=300s;
4243
resolver_timeout 5s;
4344

0 commit comments

Comments
 (0)