Skip to content

Commit 1a7c59b

Browse files
committed
kms: enable metrics by default
1 parent 4bc0099 commit 1a7c59b

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

kms/kms.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ download_timeout = "2m"
4040

4141
[core.metrics]
4242
# Expose unauthenticated Prometheus metrics on /metrics.
43-
# Keep disabled unless the KMS RPC listener is protected by network policy
43+
# Disable this if the KMS RPC listener is not protected by network policy
4444
# or another access-control layer.
45-
enabled = false
45+
enabled = true
4646

4747
[core.auth_api]
4848
type = "webhook"

kms/src/config.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,12 @@ pub(crate) struct KmsConfig {
4646
/// agent socket.
4747
#[serde(default = "default_true")]
4848
pub enforce_self_authorization: bool,
49-
#[serde(default)]
5049
pub metrics: MetricsConfig,
5150
}
5251

53-
#[derive(Debug, Clone, Deserialize, Default)]
52+
#[derive(Debug, Clone, Deserialize)]
5453
pub(crate) struct MetricsConfig {
5554
/// Whether to expose the unauthenticated Prometheus `/metrics` endpoint.
56-
#[serde(default)]
5755
pub enabled: bool,
5856
}
5957

0 commit comments

Comments
 (0)