refactor(api): rename app state constructors

Author: kvinwang

guest-agent-simulator/src/main.rs

@@ -125,7 +125,7 @@ async fn main() -> Result<()> {
     }
     let attestation =
         simulator::load_versioned_attestation(&sim_config.simulator.attestation_file)?;
-    let state = AppState::new(
+    let state = AppState::new_with_platform(
         sim_config.core,
         Arc::new(SimulatorPlatform::new(
             attestation,

guest-agent/src/main.rs

@@ -27,7 +27,7 @@ async fn main() -> Result<()> {
     }
     let args = Args::parse();
     let figment = config::load_config_figment(args.config.as_deref());
-    let state = AppState::new_real(figment.focus("core").extract()?)
+    let state = AppState::new(figment.focus("core").extract()?)
         .await
         .context("Failed to create app state")?;
     run_server(state, figment, args.watchdog).await

guest-agent/src/rpc_service.rs

@@ -132,7 +132,10 @@ impl AppState {
         });
     }
 
-    pub async fn new(config: Config, platform: Arc<dyn PlatformBackend>) -> Result<Self> {
+    pub async fn new_with_platform(
+        config: Config,
+        platform: Arc<dyn PlatformBackend>,
+    ) -> Result<Self> {
         let keys: AppKeys = serde_json::from_str(&fs::read_to_string(&config.keys_file)?)
             .context("Failed to parse app keys")?;
         let sys_config: SysConfig =
@@ -157,8 +160,8 @@ impl AppState {
         Ok(me)
     }
 
-    pub async fn new_real(config: Config) -> Result<Self> {
-        Self::new(config, Arc::new(RealPlatform)).await
+    pub async fn new(config: Config) -> Result<Self> {
+        Self::new_with_platform(config, Arc::new(RealPlatform)).await
     }
 
     pub fn config(&self) -> &Config {