review: address Copilot comments

- OvmfVariant doc: clarify that the firmware switch and the runtime
  version-to-variant cutoff aren't the same line. 0.5.9 already ships
  the new OVMF, but the heuristic in ovmf_variant_for_version
  deliberately draws the boundary at 0.5.10.
- dstack-mr CLI: drop unnecessary image_info.cmdline.clone() — the
  rest of the struct stays usable via partial move (ovmf_variant is
  Copy, version is only borrowed).

Author: kvinwang

dstack-mr/cli/src/main.rs

@@ -103,7 +103,7 @@ fn main() -> Result<()> {
             let firmware_path = parent_dir.join(&image_info.bios).display().to_string();
             let kernel_path = parent_dir.join(&image_info.kernel).display().to_string();
             let initrd_path = parent_dir.join(&image_info.initrd).display().to_string();
-            let cmdline = image_info.cmdline.clone() + " initrd=initrd";
+            let cmdline = image_info.cmdline + " initrd=initrd";
 
             // CLI flag wins, then the explicit `ovmf_variant` in metadata.json,
             // and finally the OS version field. Older metadata.json files may

dstack-types/src/lib.rs

@@ -11,10 +11,17 @@ use size_parser::human_size;
 
 /// Identifies which OVMF flavour the guest image was built with.
 ///
-/// dstack switched OVMF from an untagged 2024-09 snapshot to edk2-stable202505 in
-/// the run-up to 0.5.9 (commit f9f11f3 on meta-dstack). The newer firmware emits
-/// more boot-time measurement events into RTMR[0], so quote replay needs a
-/// different expected event list for the two flavours.
+/// The firmware switch happened in meta-dstack commit f9f11f3 (upgrade from an
+/// untagged 2024-09 snapshot to edk2-stable202505): 0.5.7 and earlier shipped
+/// `Pre202505`, 0.5.9 onwards ships `Stable202505`. The newer firmware emits
+/// more boot-time events into RTMR[0], so quote replay needs a different
+/// expected event list for the two flavours.
+///
+/// When the variant isn't carried explicitly in `VmConfig`, the runtime cutoff
+/// rule in `dstack_mr::ovmf_variant_for_version` draws the line at OS version
+/// `0.5.10` (and again at `0.6.1`) — a deliberate policy decision that doesn't
+/// follow the firmware-flip date exactly. See that function's docs for the
+/// authoritative selection rule.
 #[derive(Deserialize, Serialize, Debug, Clone, Copy, PartialEq, Eq, Default)]
 #[serde(rename_all = "snake_case")]
 pub enum OvmfVariant {