Commit 5b6b57d
committed
refactor: drop version field from v2 canonical JSON
The v2 canonical JSON previously included a "version":2 field to make
the hashed content self-describing. Per review feedback, version is
now carried out-of-band via RuntimeEvent.version (scale/serde) only,
and the hashed content is a clean {event, event_type, payload} JSON.
v2 canonical JSON is now:
{"event":"<name>","event_type":134217729,"payload":"<hex>"}
Updates:
- canonical_event_json_v2: drop "version" key
- doc comments in runtime_events.rs / tdx.rs / dstack-types/lib.rs
updated to reflect the new v2 format
- tests: expected canonical strings, the hash_input v2 assertion, and
the key-order test no longer reference "version"
Note: RuntimeEvent serde still emits "version":2 when writing events
to /run/log/dstack/runtime_events.log (serde_roundtrip_preserves_version
test covers that) — that is the on-disk format, not the hashed content.1 parent de1d4a0 commit 5b6b57d
3 files changed
Lines changed: 11 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
153 | | - | |
154 | 152 | | |
| 153 | + | |
| 154 | + | |
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
160 | | - | |
161 | 160 | | |
162 | 161 | | |
163 | 162 | | |
| |||
208 | 207 | | |
209 | 208 | | |
210 | 209 | | |
211 | | - | |
| 210 | + | |
212 | 211 | | |
213 | 212 | | |
214 | 213 | | |
| |||
269 | 268 | | |
270 | 269 | | |
271 | 270 | | |
272 | | - | |
| 271 | + | |
273 | 272 | | |
274 | 273 | | |
275 | 274 | | |
| |||
281 | 280 | | |
282 | 281 | | |
283 | 282 | | |
284 | | - | |
285 | 283 | | |
286 | 284 | | |
287 | | - | |
288 | 285 | | |
289 | 286 | | |
290 | 287 | | |
291 | 288 | | |
292 | 289 | | |
293 | 290 | | |
294 | 291 | | |
295 | | - | |
| 292 | + | |
296 | 293 | | |
297 | 294 | | |
298 | 295 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
| 186 | + | |
187 | 187 | | |
188 | | - | |
| 188 | + | |
189 | 189 | | |
| 190 | + | |
190 | 191 | | |
191 | 192 | | |
192 | 193 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments