fix(sdk): address code review feedback for release workflows

- Align tsconfig lib to es2020 to match target in all three tsconfig files
- Remove machine-local .claude/settings.local.json from tracking and add
  to .gitignore
- Remove non-reproducible npm@latest install step from JS workflow
- Fix JS workflow version extraction: read from package.json on
  workflow_dispatch, verify tag matches package.json on tag push
- Fix Python workflow version extraction: read from pyproject.toml on
  workflow_dispatch, verify tag matches pyproject.toml on tag push

Author: Leechael

.github/workflows/js-sdk-release.yml

@@ -33,11 +33,6 @@ jobs:
           node-version: '20'
           registry-url: 'https://registry.npmjs.org'
 
-      - name: Upgrade npm for OIDC support
-        run: |
-          npm install -g npm@latest
-          echo "npm version: $(npm --version)"
-
       - name: Verify OIDC token availability
         run: |
           if [ -n "${ACTIONS_ID_TOKEN_REQUEST_URL}" ] && [ -n "${ACTIONS_ID_TOKEN_REQUEST_TOKEN}" ]; then
@@ -71,21 +66,29 @@ jobs:
         working-directory: sdk/js
         run: npm run build
 
-      - name: Determine npm dist-tag
+      - name: Determine version and npm dist-tag
         id: tag
+        working-directory: sdk/js
         run: |
-          VERSION="${GITHUB_REF_NAME#js-sdk-v}"
-          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+          PKG_VERSION=$(node -e "console.log(require('./package.json').version)")
           if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
+            VERSION="$PKG_VERSION"
             echo "tag=${{ github.event.inputs.npm_tag }}" >> "$GITHUB_OUTPUT"
           else
+            TAG_VERSION="${GITHUB_REF_NAME#js-sdk-v}"
+            if [ "$TAG_VERSION" != "$PKG_VERSION" ]; then
+              echo "::error::tag version ($TAG_VERSION) does not match package.json version ($PKG_VERSION)"
+              exit 1
+            fi
+            VERSION="$TAG_VERSION"
             # auto-detect from git tag: js-sdk-v0.5.8-beta.1 -> beta
             if echo "$VERSION" | grep -qiE '(beta|alpha|rc|preview)'; then
               echo "tag=beta" >> "$GITHUB_OUTPUT"
             else
               echo "tag=latest" >> "$GITHUB_OUTPUT"
             fi
           fi
+          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
 
       - name: Publish to npm
         working-directory: sdk/js

.github/workflows/python-sdk-release.yml

@@ -38,9 +38,31 @@ jobs:
         working-directory: sdk/python
         run: pdm build
 
-      - name: Parse version
+      - name: Parse and verify version
         id: version
-        run: echo "version=${GITHUB_REF_NAME#python-sdk-v}" >> "$GITHUB_OUTPUT"
+        working-directory: sdk/python
+        run: |
+          PKG_VERSION=$(python -c "
+          import re
+          with open('pyproject.toml') as f:
+              m = re.search(r'^version\s*=\s*\"([^\"]+)\"', f.read(), re.M)
+              print(m.group(1) if m else '')
+          ")
+          if [ -z "$PKG_VERSION" ]; then
+            echo "::error::failed to parse version from pyproject.toml"
+            exit 1
+          fi
+          if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
+            VERSION="$PKG_VERSION"
+          else
+            TAG_VERSION="${GITHUB_REF_NAME#python-sdk-v}"
+            if [ "$TAG_VERSION" != "$PKG_VERSION" ]; then
+              echo "::error::tag version ($TAG_VERSION) does not match pyproject.toml version ($PKG_VERSION)"
+              exit 1
+            fi
+            VERSION="$TAG_VERSION"
+          fi
+          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
 
       - name: Publish to PyPI
         if: github.event_name == 'push' || github.event.inputs.target == 'pypi'

sdk/js/.claude/settings.local.json

@@ -2,3 +2,5 @@ node_modules/
 dist/
 *.log
 package-lock.json
+.claude/settings.local.json
+.claude/settings.local.json.license

sdk/js/.claude/settings.local.json.license

@@ -3,7 +3,7 @@
   "compilerOptions": {
     "target": "es2020",
     "module": "es2015",
-    "lib": ["es2018", "dom"],
+    "lib": ["es2020", "dom"],
     "outDir": "./dist/browser",
     "declaration": true,
     "declarationMap": true,

sdk/js/.gitignore

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "target": "es2020",
     "module": "commonjs",
-    "lib": ["es2018"],
+    "lib": ["es2020"],
     "declaration": true,
     "declarationMap": true,
     "sourceMap": true,

sdk/js/tsconfig.browser.json

@@ -3,7 +3,7 @@
   "compilerOptions": {
     "target": "es2020",
     "module": "commonjs",
-    "lib": ["es2018"],
+    "lib": ["es2020"],
     "outDir": "./dist/node",
     "declaration": true,
     "declarationMap": true,