Update dstack python SDK.#292
Merged
Merged
Conversation
Leechael
marked this pull request as ready for review
August 14, 2025 13:35
kvinwang
reviewed
Aug 15, 2025
kvinwang
left a comment
kvinwang
left a comment
Collaborator
There was a problem hiding this comment.
I wonder if there is a elegant way to reuse the code logic between sync and async clients.
Collaborator
|
Tried reuse the async/sync code logic here: #299 |
…ss different languages.
…tead of paths - Add PATH_PREFIX constant to both DstackClient and AsyncDstackClient - Change _send_rpc_request parameter from 'path' to 'method' - Construct full path internally using PATH_PREFIX + method - Update all RPC calls to pass method names without leading slash 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…request
- Replace direct HTTP client calls with _send_rpc_request("Version", {})
- Consistent with other methods in the class
- Reduces code duplication and maintains abstraction
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
… in same context.
Leechael
force-pushed
the
feat-sdk-python
branch
from
August 15, 2025 15:35
4937d93 to
07ef2e6
Compare
Leechael
force-pushed
the
feat-sdk-python
branch
from
August 15, 2025 15:51
e170539 to
3ad0da1
Compare
Leechael
force-pushed
the
feat-sdk-python
branch
from
August 16, 2025 06:08
f4c8ef9 to
3220ce6
Compare
Leechael
force-pushed
the
feat-sdk-python
branch
from
August 18, 2025 09:03
c93cc1a to
69be206
Compare
kvinwang
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.