Add Verifiable Message Signing#360
Merged
Merged
Conversation
kvinwang
marked this pull request as ready for review
October 9, 2025 00:30
kvinwang
reviewed
Oct 9, 2025
kvinwang
left a comment
kvinwang
left a comment
Collaborator
There was a problem hiding this comment.
Let's also update the client SDKs under sdk/. It is also recommended to add a corresponding Verify() API as a counterpart to Sign().
kvinwang
reviewed
Oct 16, 2025
kvinwang
reviewed
Oct 16, 2025
kvinwang
reviewed
Oct 16, 2025
kvinwang
reviewed
Oct 16, 2025
Co-authored-by: Kevin Wang <wy721@qq.com>
kvinwang
reviewed
Oct 22, 2025
kvinwang
left a comment
kvinwang
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thank you very much! We can merge it after the conflicts are resolved.
Contributor
Author
|
@kvinwang, fixed all the conflicts. |
Collaborator
|
@iKapitonau Could you take a look at the test failures? |
Contributor
Author
|
@kvinwang, done. Please re-run all checks. |
kvinwang
added a commit
that referenced
this pull request
Jan 19, 2026
Add Verifiable Message Signing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.