Retry create state app RPC on failure with exponential backoff#364
Closed
Evrard-Nil wants to merge 3 commits into
Closed
Retry create state app RPC on failure with exponential backoff#364Evrard-Nil wants to merge 3 commits into
Evrard-Nil wants to merge 3 commits into
Conversation
…rnal_v0 and run_internal
Contributor
|
Thanks for your contribution! I will let @kvinwang to review it. |
Collaborator
|
This doesn't resolve the issue since Docker also creates a directory inside the container. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces reliability improvements to certificate handling and socket file management in the guest agent. The main changes are the addition of exponential backoff retry logic for certificate requests and cleanup of existing Unix socket files or directories before binding. These updates help prevent startup failures due to transient certificate service errors or leftover socket files.
Certificate Request Reliability:
AppState,DstackGuestRpc, andTappdRpcimplementations to handle transient failures gracefully. Retries are logged with warnings and delays increase exponentially. [1] [2] [3] [4]Socket File Management:
run_internal_v0andrun_internalfunctions, preventing binding errors due to leftover files. [1] [2]