fix(verifier): remove pccs_url from public API to prevent SSRF#447
Merged
Conversation
Remove the pccs_url parameter from the VerificationRequest struct to prevent potential SSRF attacks where a malicious client could specify an arbitrary URL. The PCCS URL is now only configurable via the server configuration file. Changes: - Remove pccs_url field from VerificationRequest in types.rs - Add pccs_url to CvmVerifier struct instead of passing per-request - Update all CvmVerifier::new() calls to pass pccs_url from config - Update README to reflect the configuration-only approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the pccs_url parameter from the VerificationRequest struct to prevent potential SSRF attacks where a malicious client could specify an arbitrary URL. The PCCS URL is now only configurable via the server configuration file.
Changes: