Skip to content

fix(kms): set user-agent for auth api requests and improve error logging #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvinwang merged 2 commits into from
Mar 6, 2026
Merged

fix(kms): set user-agent for auth api requests and improve error logging #525

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79b8b8d
fix(kms): set user-agent for auth api requests and improve error logging
Leechael Mar 3, 2026
802e80a
refactor(kms): extract generic http_get/http_post helpers
kvinwang Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions kms/src/main_service/upgrade_authority.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// SPDX-License-Identifier: Apache-2.0

use crate::config::AuthApi;
use anyhow::{bail, Result};
use anyhow::{bail, Context, Result};
use ra_tls::attestation::AttestationMode;
use serde::{Deserialize, Serialize};
use serde_human_bytes as hex_bytes;
Expand Down Expand Up @@ -60,6 +60,14 @@ pub(crate) struct GetInfoResponse {
pub app_implementation: Option<String>,
}

fn http_client() -> Result<reqwest::Client> {
static USER_AGENT: &str = concat!("dstack-kms/", env!("CARGO_PKG_VERSION"));
reqwest::Client::builder()
.user_agent(USER_AGENT)
.build()
.context("failed to build http client")
}

impl AuthApi {
pub async fn is_app_allowed(&self, boot_info: &BootInfo, is_kms: bool) -> Result<BootResponse> {
match self {
Expand All @@ -69,7 +77,7 @@ impl AuthApi {
gateway_app_id: dev.gateway_app_id.clone(),
}),
AuthApi::Webhook { webhook } => {
let client = reqwest::Client::new();
let client = http_client()?;
let path = if is_kms {
"bootAuth/kms"
} else {
Expand All @@ -95,10 +103,16 @@ impl AuthApi {
app_implementation: None,
}),
AuthApi::Webhook { webhook } => {
let client = reqwest::Client::new();
let client = http_client()?;
let response = client.get(&webhook.url).send().await?;
println!("url: {}", webhook.url);
let info: AuthApiInfoResponse = response.json().await?;
let status = response.status();
let body = response.text().await?;
let info: AuthApiInfoResponse = serde_json::from_str(&body).with_context(|| {
format!(
"failed to decode auth api response from {}, status={status}, body={body}",
webhook.url
)
})?;
Ok(GetInfoResponse {
is_dev: false,
kms_contract_address: Some(info.kms_contract_addr.clone()),
Expand Down