Skip to content

fix(vmm): hide app url until instance id is ready - #628

Merged
kvinwang merged 1 commit into
masterfrom
fix/vmm-info-no-empty-app-url-upstream
Apr 2, 2026
Merged

fix(vmm): hide app url until instance id is ready#628
kvinwang merged 1 commit into
masterfrom
fix/vmm-info-no-empty-app-url-upstream

Conversation

@kvinwang

@kvinwang kvinwang commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • treat empty instance_id values as unavailable
  • avoid generating a gateway dashboard URL until the instance ID exists
  • add unit tests for the instance-id sanitization helpers

Testing

  • cargo test -p dstack-vmm sanitize_optional -- --nocapture

@kvinwang
kvinwang force-pushed the fix/vmm-info-no-empty-app-url-upstream branch from ca36b9c to 3de3421 Compare April 2, 2026 02:39
@kvinwang
kvinwang merged commit e43d8a1 into master Apr 2, 2026
15 checks passed
@kvinwang
kvinwang deleted the fix/vmm-info-no-empty-app-url-upstream branch July 20, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kvinwang