Clean up stale verifier example, comments, doc rot, and harden E2EE#74
Merged
Conversation
h4x3rotab
force-pushed
the
aci-68-cleanups
branch
2 times, most recently
from
8412876 to
54b6b21
Compare
- Rewrite examples/verify_aci_artifacts.rs against current artifact shapes (receipt top-level model; upstream.verified upstream_name/provider_type/ session_id/claims, no inline evidence or vendor) and add the spec §10 deep audit: recompute the content-addressed session_id (§9.2 null-restoration) and check evidence.data against evidence.digest. - Fix stale "returned to the caller as headers" comments on MiddlewareForwarded / MiddlewareStreamingForwarded; no such headers are emitted, the receipt is the committed reference. - Fix docs/attested-session-system.md purpose tags: the real domain-separation tags are aci.report_data.v1 and aci.keyset.endorsement.v1, and receipts carry none. - Warn at startup when E2EE is disabled (empty supported_e2ee_versions). The ACI E2EE nonce floor (issue #68 item) landed independently in #75 (exact 64-hex rule), so it is dropped here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
h4x3rotab
force-pushed
the
aci-68-cleanups
branch
from
54b6b21 to
f63de55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanups from
docs/reviews/aci-spec-conformance-gaps.mditems 10–12 and 15. Rebased onto currentmain.examples/verify_aci_artifacts.rs: rewritten against current artifact shapes (receipt top-levelmodel;upstream.verifiedcarriesupstream_name/provider_type+session_id/claims, no inline evidence orvendor). Adds the spec §10 deep audit — recompute the content-addressedsession_id(§9.2, incl. the null-restoration rule), checkevidence.dataagainstevidence.digest, and confirm the receipt references the session — plus transparency-event consistency. Verified end-to-end against real report/receipt/session artifacts.wire.rs: fix the stale "returned to the caller as headers" comments onMiddlewareForwarded/MiddlewareStreamingForwarded; no such headers are emitted, the receipt is the committed reference.docs/attested-session-system.md: cite the real domain-separation tags (aci.report_data.v1,aci.keyset.endorsement.v1) and note receipts carry none.supported_e2ee_versions).The E2EE nonce-floor item (#68) landed independently in #75 as an exact 64-hex-char rule, so it is dropped here.
cargo fmt,cargo clippy --all-targets(clean), andcargo test(343 passing) all green.Closes #68
🤖 Generated with Claude Code