Refactor RedirectMiddleware and NotFoundMiddleware to use primary constructors, removing redundant fields

Author: maartenba

server/src/Docs.Web/Middleware/NotFoundMiddleware.cs

@@ -3,22 +3,15 @@ namespace Docs.Web.Middleware;
 /// <summary>
 /// Middleware that serves a custom 404.html page when the response status code is 404.
 /// </summary>
-public class NotFoundMiddleware : IMiddleware
+public class NotFoundMiddleware(IWebHostEnvironment environment) : IMiddleware
 {
-    private readonly IWebHostEnvironment _environment;
-
-    public NotFoundMiddleware(IWebHostEnvironment environment)
-    {
-        _environment = environment;
-    }
-
     public async Task InvokeAsync(HttpContext context, RequestDelegate next)
     {
         await next(context);
 
         if (context.Response.StatusCode == 404 && !context.Response.HasStarted)
         {
-            var notFoundPath = Path.Combine(_environment.WebRootPath, "404.html");
+            var notFoundPath = Path.Combine(environment.WebRootPath, "404.html");
 
             if (File.Exists(notFoundPath))
             {

server/src/Docs.Web/Middleware/RedirectMiddleware.cs

@@ -3,20 +3,13 @@ namespace Docs.Web.Middleware;
 /// <summary>
 /// Middleware that redirects old URLs to new destinations using a preloaded redirect map (301 permanent).
 /// </summary>
-public class RedirectMiddleware : IMiddleware
+public class RedirectMiddleware(IReadOnlyDictionary<string, string> redirectMap) : IMiddleware
 {
-    private readonly IReadOnlyDictionary<string, string> _redirectMap;
-
-    public RedirectMiddleware(IReadOnlyDictionary<string, string> redirectMap)
-    {
-        _redirectMap = redirectMap;
-    }
-
     public async Task InvokeAsync(HttpContext context, RequestDelegate next)
     {
         var path = context.Request.Path.Value?.TrimEnd('/') ?? "";
 
-        if (_redirectMap.TryGetValue(path, out var destination))
+        if (redirectMap.TryGetValue(path, out var destination))
         {
             var queryString = context.Request.QueryString.HasValue ? context.Request.QueryString.Value : "";
             context.Response.StatusCode = 301;