Skip to content

Commit 4a2d827

Browse files
committed
Fix several broken links
1 parent b65200a commit 4a2d827

3 files changed

Lines changed: 41 additions & 8 deletions

File tree

astro/src/content/docs/identityserver/upgrades/identityserver4-v4-to-duende-identityserver-v6.md

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,25 @@ This upgrade guide covers upgrading from IdentityServer4 v4.1.x to Duende Identi
1616

1717
:::note
1818
With any major release, there is always the possibility of some breaking changes.
19-
[This issue tracks](https://github.com/DuendeSoftware/products/issues/351) the list of updates where a breaking change might affect your use of IdentityServer. It would be useful to review it to understand if any of these changes affect you.
19+
20+
<details>
21+
<summary>List of updates where a breaking change might affect your use of IdentityServer.</summary>
22+
23+
* [Quickstart UI updated to use razor pages](https://github.com/DuendeSoftware/IdentityServer/pull/263)
24+
* [Addition of cancellation token to store APIs](https://github.com/DuendeSoftware/IdentityServer/pull/405)
25+
* [Store DbContext ctors to support DbContext pooling](https://github.com/DuendeSoftware/IdentityServer/pull/260)
26+
* [CustomRedirectResult returnUrl changes](https://github.com/DuendeSoftware/IdentityServer/pull/358)
27+
* [Add missing columns for created, updated, etc to EF entities](https://github.com/DuendeSoftware/IdentityServer/pull/356)
28+
* [Add unique constraints to EF tables where duplicate records not allowed](https://github.com/DuendeSoftware/IdentityServer/pull/355)
29+
* [Added grant handle versioning suffix](https://github.com/DuendeSoftware/IdentityServer/pull/404)
30+
* [Many HttpContext extensions marked obsolete](https://github.com/DuendeSoftware/IdentityServer/pull/414)
31+
* [New APIs to the ICache interface](https://github.com/DuendeSoftware/IdentityServer/pull/421)
32+
* [New Client columns for CIBA](https://github.com/DuendeSoftware/IdentityServer/pull/498)
33+
* [openid no longer implicit in OidcProvider scope collection](https://github.com/DuendeSoftware/IdentityServer/pull/507)
34+
* [JwtRequestValidator signature changes](https://github.com/DuendeSoftware/IdentityServer/pull/537)
35+
* [Changes in AppAuth URL validator for logout](https://github.com/DuendeSoftware/IdentityServer/pull/619)
36+
* [Use of EmailClaimType option in ASP.NET Identity integration](https://github.com/DuendeSoftware/IdentityServer/pull/625)
37+
</details>
2038
:::
2139

2240
## Step 1: Update to .NET 6

astro/src/content/docs/identityserver/upgrades/v5_2-to-v6_0.md

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,25 @@ The most significant aspect of this upgrade is that Duende IdentityServer v6.0 t
1414

1515
:::note
1616
With any major release, there is always the possibility of some breaking changes.
17-
[This issue tracks](https://github.com/DuendeSoftware/products/issues/351) the list of updates where a breaking change might affect your use of IdentityServer. It would be useful to review it to understand if any of these changes affect you.
17+
18+
<details>
19+
<summary>List of updates where a breaking change might affect your use of IdentityServer.</summary>
20+
21+
* [Quickstart UI updated to use razor pages](https://github.com/DuendeSoftware/IdentityServer/pull/263)
22+
* [Addition of cancellation token to store APIs](https://github.com/DuendeSoftware/IdentityServer/pull/405)
23+
* [Store DbContext ctors to support DbContext pooling](https://github.com/DuendeSoftware/IdentityServer/pull/260)
24+
* [CustomRedirectResult returnUrl changes](https://github.com/DuendeSoftware/IdentityServer/pull/358)
25+
* [Add missing columns for created, updated, etc to EF entities](https://github.com/DuendeSoftware/IdentityServer/pull/356)
26+
* [Add unique constraints to EF tables where duplicate records not allowed](https://github.com/DuendeSoftware/IdentityServer/pull/355)
27+
* [Added grant handle versioning suffix](https://github.com/DuendeSoftware/IdentityServer/pull/404)
28+
* [Many HttpContext extensions marked obsolete](https://github.com/DuendeSoftware/IdentityServer/pull/414)
29+
* [New APIs to the ICache interface](https://github.com/DuendeSoftware/IdentityServer/pull/421)
30+
* [New Client columns for CIBA](https://github.com/DuendeSoftware/IdentityServer/pull/498)
31+
* [openid no longer implicit in OidcProvider scope collection](https://github.com/DuendeSoftware/IdentityServer/pull/507)
32+
* [JwtRequestValidator signature changes](https://github.com/DuendeSoftware/IdentityServer/pull/537)
33+
* [Changes in AppAuth URL validator for logout](https://github.com/DuendeSoftware/IdentityServer/pull/619)
34+
* [Use of EmailClaimType option in ASP.NET Identity integration](https://github.com/DuendeSoftware/IdentityServer/pull/625)
35+
</details>
1836
:::
1937

2038
## Step 1: Update to .NET 6

astro/src/content/docs/identityserver/upgrades/v6_2-to-v6_3.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,12 @@ Some organizations prefer to use other tools for managing schema changes. You're
8383
IdentityServer depends on ASP.NET Data Protection. Data Protection encrypts and signs data using keys managed by ASP.NET. Those keys are isolated by application name, which by default is set to the content root path of the host. This prevents multiple applications from sharing encryption keys, which is necessary to protect your encryption against certain forms of attack. However, this means that if your content root path changes, the default settings for data protection will prevent you from using your old keys. Beginning in .NET 6, the content root path was normalized so that it ends with a directory separator. In .NET 7 that change was reverted. This means that your content root path might change if you upgrade from .NET 6 to .NET 7. This can be mitigated by explicitly setting the application name and removing the separator character. See [Microsoft's documentation for more information](https://learn.microsoft.com/en-us/aspnet/core/security/data-protection/configuration/overview?view=aspnetcore-7.0#setapplicationname).
8484

8585
## Step 4: Breaking changes
86-
- A new `ITokenCleanupService` interface has been extracted from the `TokenCleanupService`, and IdentityServer now depends on that interface, rather than the service itself. Customizations of `TokenCleanupService` that previously were implemented by deriving from that class and registering the derived class in the ASP.NET Core service provider need to
86+
87+
- A [new `ITokenCleanupService` interface](https://github.com/DuendeSoftware/products/pull/1215) has been extracted from the `TokenCleanupService`, and IdentityServer now depends on that interface, rather than the service itself. Customizations of `TokenCleanupService` that previously were implemented by deriving from that class and registering the derived class in the ASP.NET Core service provider need to
8788
- Register the derived class as an implementation of `ITokenCleanupService`, and
8889
- Remove the `IServerSideSessionsMarker` from any calls to the base constructor.
89-
90-
See issue [#981](https://github.com/DuendeSoftware/products/issues/981).
91-
92-
- The `TokenCleanupService.RemoveExpiredGrantsAsync` method was renamed to `CleanupGrantsAsync` to reflect that it performs all grant cleanup work, including removing consumed grants and expired device codes in addition to expired grants. In the strictest sense, this is a breaking change, but it is very unlikely to cause issues during an upgrade because even though `RemoveExpiredGrantsAsync` was public, it was not virtual. If you were using `RemoveExpiredGrantsAsync` elsewhere, update your code to use the new name.
9390

94-
See issue [#981](https://github.com/DuendeSoftware/products/issues/981).
91+
- The `TokenCleanupService.RemoveExpiredGrantsAsync` method was [renamed to `CleanupGrantsAsync`](https://github.com/DuendeSoftware/products/pull/1215) to reflect that it performs all grant cleanup work, including removing consumed grants and expired device codes in addition to expired grants. In the strictest sense, this is a breaking change, but it is very unlikely to cause issues during an upgrade because even though `RemoveExpiredGrantsAsync` was public, it was not virtual. If you were using `RemoveExpiredGrantsAsync` elsewhere, update your code to use the new name.
9592

9693
- The value of the `typ` claim in the header of Logout tokens has changed to `logout+jwt`, which complies with OpenID Connect Back-Channel Logout 1.0. Clients that were previously validating the `typ` need to be updated, or the old `typ` can continue to be used via the new `LogoutTokenJwtType` configuration option.
9794

0 commit comments

Comments
 (0)