Skip to content

Expanded description and added code samples to demonstrate api resources and how they affect aud claim#1067

Merged
maartenba merged 14 commits intomainfrom
ar/more-specific-isolation
Apr 24, 2026
Merged

Expanded description and added code samples to demonstrate api resources and how they affect aud claim#1067
maartenba merged 14 commits intomainfrom
ar/more-specific-isolation

Conversation

@ProgrammerAL
Copy link
Copy Markdown
Contributor

  • Expanded description of, and added code samples to demonstrate, api resources and how they affect aud claim
  • Inlined completed code samples of IdentityServer application and client to show result of requests

The code samples added have 2 file-based apps to let people experiment with combinations. The down side of this approach is the version of the samples is hard coded, releasing new versions of IdentityServer mean we have to update these samples. If anyone thinks this should be in a blog post instead, I'm fine removing it.

@ProgrammerAL ProgrammerAL self-assigned this Apr 22, 2026
@ProgrammerAL ProgrammerAL added the documentation Improvements or additions to documentation label Apr 22, 2026
@maartenba maartenba added this to the 2026-Q2 milestone Apr 23, 2026
Copy link
Copy Markdown
Member

@maartenba maartenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, some cosmetic comments mostly.

Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Comment thread astro/src/content/docs/identityserver/fundamentals/resources/isolation.md Outdated
Console.WriteLine($"Protocol error response: {response.Raw}");
}
}
```
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End with expected output or some summary on what folks should observe from running the above samples?

ProgrammerAL and others added 10 commits April 23, 2026 10:35
…solation.md

Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md

Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md

Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md

Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md

Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md

Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md

Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md

Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
@ProgrammerAL
Copy link
Copy Markdown
Contributor Author

@maartenba I combined some of your comments into one action. I moved the isolation content into a folder. The main page is what it was before these edits (plus minor changes), and added a new page with the content from this PR. Let me know what you think of that concept.

The links stay the same. I also didn't include the output of the sample code because a summary of the output is that table just before the sample code section.

Copy link
Copy Markdown
Member

@maartenba maartenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks @ProgrammerAL !

@wcabus can you also have a quick look? (the samples file is new, the other is just a move)

Copy link
Copy Markdown
Member

@wcabus wcabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already had a look before, didn't have additional comments 🙂

@maartenba maartenba merged commit 2f62601 into main Apr 24, 2026
6 of 7 checks passed
@maartenba maartenba deleted the ar/more-specific-isolation branch April 24, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants