Conversation
maartenba
left a comment
There was a problem hiding this comment.
Reviewed, some cosmetic comments mostly.
| Console.WriteLine($"Protocol error response: {response.Raw}"); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
End with expected output or some summary on what folks should observe from running the above samples?
…solation.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…solation.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
… that folder for the sample
|
@maartenba I combined some of your comments into one action. I moved the isolation content into a folder. The main page is what it was before these edits (plus minor changes), and added a new page with the content from this PR. Let me know what you think of that concept. The links stay the same. I also didn't include the output of the sample code because a summary of the output is that table just before the sample code section. |
There was a problem hiding this comment.
Sounds good, thanks @ProgrammerAL !
@wcabus can you also have a quick look? (the samples file is new, the other is just a move)
wcabus
left a comment
There was a problem hiding this comment.
Already had a look before, didn't have additional comments 🙂
audclaimThe code samples added have 2 file-based apps to let people experiment with combinations. The down side of this approach is the version of the samples is hard coded, releasing new versions of IdentityServer mean we have to update these samples. If anyone thinks this should be in a blog post instead, I'm fine removing it.