Update OIDC client documentation with examples and clarifications#683
Merged
Conversation
Added expanded examples and code snippets for `OidcClient` configuration, logging, automatic mode, and manual mode. Clarified the use of `IBrowser` in authentication flows and highlighted differences between modes, providing links to relevant references and structured explanations.
maartenba
approved these changes
Apr 23, 2025
Member
maartenba
left a comment
There was a problem hiding this comment.
Couple of minor edits, looks good!
Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded
OidcClientdocumentation to include detailed examples, explanations for configuration, logging, and authentication modes. Enhanced clarity onIBrowserusage and mode distinctions, with links to additional references for ease of understanding.