Updates Hangprinter support#1230
Conversation
|
Added the commit that allows one force for each motor, like I have two other features that I've ommitted here. Tell me if you want them.
|
|
Thanks for your PR.
|
|
PS - if we are going to cache the direction setting for remote drivers then the way I would like to do this is to add the direction setting to class DriverData (see src/Movement/StepperDrivers/DriverData.h) so that we can include it in the object model. Is that the way you have implemented it? |
The Caching: I had put it in ExpansionBoardData. I changed that now to cache them in DriverData instead. I also added a commit that exposes driver directions in the object model. |
|
Oh I should have fetched first. It seems you already implementet the caching in DriverData? |
110c62d to
7253bc5
Compare
|
There was a lot to untangle there but I think I've got it all corrected now. It builds and runs cleanly in the RRF_HOST_BUILD + simulator, both the gcode terminal (http server mode) and the full gcode execution path. It also builds cleanly for the Duet3_MB6HC target in Eclipse. |
|
I'm looking forward to assist in getting RRF_HOST_BUILD into upstream. It's been a real game changer for my RRF related workflows |
dc42
left a comment
There was a problem hiding this comment.
Hi, please review my suggested changes.
Also makes Move::GetDirectionValue not inline anymore, so HangprinterKinematics can link to it.
|
Done. 👌 Just let me know if you find more things to fix before merge |
|
@dc42 Any news on this PR's status? |
Hi, I just rebased my code that I run in the simulator onto 3.7-dev. In this PR I've extracted HangprinterKinematics.{h,cpp} from my RRF fork and made it compile nicely with your upstream 3.7-dev branch in the various involved repos.
It includes
See it running in the simulator at https://tobbelobb.github.io/hp-sim5/hp-sim-3d/