My PHP Task#160
Open
Chigoz169 wants to merge 1 commit into
Open
Conversation
Contributor
Chigoz169
commented
Feb 15, 2020
Chigoz169
commented
- Task: PHP
- I added a CSS file named "prod.css" and it was designed for the product log page.
- I added also an Overview page as asked by the tutor.
- My main product page is titled "index1.php".
- A connection file for the PHP product page was also inclusive.
taiwo-ladipo
requested changes
Feb 16, 2020
| <input type="text" name="number" required="required"><br> | ||
| <label>Date</label><br> | ||
| <input type="datetime-local" name="timestamp" required="required"><br> | ||
| <select name="brand" class="brand" required="required"> |
Contributor
There was a problem hiding this comment.
Well done @Chigoz169
Can you fetch these brands from the database?
This is a requirement in the task specification
Build in such a way that an item whose brand we don’t know cannot be uploaded to our database. Also add functionality to know the exact day the Product was uploaded.
| foreach ($data as $row) { | ||
| echo '<tr> | ||
| <td>'.$row["id"].'</td> | ||
| <td>'.$row["Brand_id"].'</td> |
Contributor
There was a problem hiding this comment.
Can you display the brand name here instead of the id for readability?
JohnItoo
added
the
waiting for scholar
kunmi02
suggested changes
Feb 19, 2020
| <option value="id">Brand id</option> | ||
| <option value="1">Apple</option> | ||
| <option value="2">Armani</option> | ||
| <option value="3">Burberry</option> |
Contributor
There was a problem hiding this comment.
Good Job @Chigoz169
I believe you can have this brand class in an array then fetch from it instead of having a long list of option tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.