Skip to content

uxdesign, landing, page, login page and database task#170

Open
bolaring wants to merge 7 commits into
Dufuna-CodeCamp:masterfrom
bolaring:master
Open

uxdesign, landing, page, login page and database task#170
bolaring wants to merge 7 commits into
Dufuna-CodeCamp:masterfrom
bolaring:master

Conversation

@bolaring
Copy link
Copy Markdown

Task:

I
I

kehindemary
kehindemary previously approved these changes Mar 17, 2020
Comment thread submissions/bolarinwa_fasanmi/HTML/landingpage.html
@beccadaniel beccadaniel added the waiting for scholar Mentor has reviewed and needs scholars input. label Mar 25, 2020


</div>
<div class="box">
Copy link
Copy Markdown
Author

@bolaring bolaring Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

landing page correction on code line 63, close div tag 65.

please check for the correction through the docs link below. thanks.

Suggested change
<div class="box">
<div class="box">
```suggestion
<div class="box">
``

Comment thread submissions/bolarinwa_fasanmi/HTML/landingpage.html
</ul>

</nav>
</span>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This span closing tag does not have an opening tag. You should remove it if it's not needed.


<div class="product">
<div class="product_box">
<div id="product_image">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This id="product_image" is used in a couple more places. An id should be unique. If you need to make use of it in more than one place, you should consider using a class instead.

</div>

<div class="product_box">
<div id="product_image">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here as the previous comment.

</div>

<div class="product_box">
<div id="product_image">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well, id should be unique. Consider using a class instead.



</div>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is supposed to be a closing div tag here for the div class="section" listed above.

<main>

<section>
<div class="section">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This div does not have a closing tag.

correction/review of landing page
@beccadaniel beccadaniel added waiting for review needs mentors review and removed waiting for scholar Mentor has reviewed and needs scholars input. labels Mar 31, 2020
@bolaring bolaring requested a review from kehindemary April 6, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for review needs mentors review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants