improve testing

Author: johnbradley

ddsc/sdk/tests/test_client.py

@@ -1,6 +1,6 @@
 from unittest import TestCase
 from ddsc.sdk.client import Client, DDSConnection, BaseResponseItem, Project, Folder, File, FileDownload, FileUpload, \
-    ChildFinder, PathToFiles, ItemNotFound, ProjectSummary
+    ChildFinder, PathToFiles, ItemNotFound, ProjectSummary, REMOTE_PATH_SEP
 from ddsc.core.util import KindType
 from mock import patch, Mock, call
 
@@ -768,6 +768,24 @@ def test_child_not_found(self):
         with self.assertRaises(ItemNotFound):
             child_finder.get_child()
 
+    def test_try_get_item_for_path_with_slash(self):
+        node = Mock()
+        result = ChildFinder.try_get_item_for_path(node, REMOTE_PATH_SEP)
+        self.assertEqual(result, node)
+
+    @patch('ddsc.sdk.client.ChildFinder.get_child_for_path')
+    def test_try_get_item_for_path_with_child_found(self, mock_get_child_for_path):
+        node = Mock()
+        result = ChildFinder.try_get_item_for_path(node, '/file.txt')
+        self.assertEqual(result, mock_get_child_for_path.return_value)
+
+    @patch('ddsc.sdk.client.ChildFinder.get_child_for_path')
+    def test_try_get_item_for_path_with_child_found(self, mock_get_child_for_path):
+        mock_get_child_for_path.side_effect = ItemNotFound()
+        node = Mock()
+        result = ChildFinder.try_get_item_for_path(node, '/file.txt')
+        self.assertEqual(result, None)
+
 
 class TestPathToFiles(TestCase):
     def test_path_creation(self):

ddsc/sdk/tests/test_dukeds.py

@@ -205,6 +205,21 @@ def test_move_file_or_folder(self, mock_client):
         DukeDS.move_file_or_folder('myproject', '/data/file1.txt', '/data/file1_bak.txt')
         mock_project.move_file_or_folder.assert_called_with('/data/file1.txt', '/data/file1_bak.txt')
 
+    @patch('ddsc.sdk.dukeds.Client')
+    def test_create_folder(self, mock_client):
+        mock_project = Mock()
+        mock_project.try_get_item_for_path.return_value = None
+        mock_project.create_folder.return_value.try_get_item_for_path.return_value = None
+        mock_project.name = 'myproject'
+        mock_client.return_value.get_projects.return_value = [
+            mock_project
+        ]
+        DukeDS.create_folder('myproject', '/data/raw')
+        mock_project.create_folder.assert_called_with("data")
+        mock_project.create_folder.return_value.create_folder.assert_called_with("raw")
+
+
+
 
 class TestSession(TestCase):
     @patch('ddsc.sdk.dukeds.Client', autospec=True)