Switch to use romanisim#100
Conversation
93c4cf2 to
ac91f55
Compare
|
romanisim.models has not yet been included in the current release (v0.13.1) of romanisim. The merge needs to wait until the next release version. |
|
I updated the romanisim dependency in pyproject.toml to point to the main branch, and all unit tests are now passing. I think the code is ready for review now. @arunkannawadi |
88819ea to
414da08
Compare
arunkannawadi
left a comment
There was a problem hiding this comment.
I have reviewed everything expect for the changes in psf.py. Given the slowness you report, I think that needs some investigation.
It seems like the efficiency issue appears in both this branch and the integrated_coadd_sim branch (which doesn't use romanisim.models yet). I'm running some tests now. |
This RP migrates the codebase to a new set of APIs in romanisim (here's an introduction of the new API), replacing all usages of galsim.roman. This change enables access to both CRDS and the roman-technical-information repository.
Current status:
noise.pyTODO / Open Questions (for this PR):
TODO / Open Questions (out of scope for this PR):