Skip to content

DY-9: Upcoming Events Section#68

Closed
csjodes wants to merge 16 commits intostagingfrom
DY-9
Closed

DY-9: Upcoming Events Section#68
csjodes wants to merge 16 commits intostagingfrom
DY-9

Conversation

@csjodes
Copy link
Copy Markdown

@csjodes csjodes commented Apr 8, 2025

No description provided.

@Samshh Samshh self-requested a review April 12, 2025 17:58
@Samshh Samshh self-requested a review April 12, 2025 18:24
Copy link
Copy Markdown
Member

@Samshh Samshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch seemed to be too divergent and is unable to rebase kindly fix merge conflicts if ever

eventDate: string;
}

export default function CountdownTimer({ eventDate }: CountdownTimerProps) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function needs to be wrapped in a useCallback()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not resolved

@ArJSarmiento ArJSarmiento mentioned this pull request Apr 22, 2025
6 tasks
@Samshh Samshh linked an issue Apr 22, 2025 that may be closed by this pull request
6 tasks
@Samshh Samshh self-requested a review April 22, 2025 09:09
Copy link
Copy Markdown
Member

@Samshh Samshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Branch is too divergent please make sure there are no conflicts to staging

eventDate: string;
}

export default function CountdownTimer({ eventDate }: CountdownTimerProps) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants