[Snyk] Security upgrade @kubernetes/client-node from 0.20.0 to 1.0.0#177
[Snyk] Security upgrade @kubernetes/client-node from 0.20.0 to 1.0.0#177Dustin4444 wants to merge 1 commit into
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-15268416 - https://snyk.io/vuln/SNYK-JS-QS-16721866
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the @kubernetes/client-node dependency in apps/kubernetes-provider/package.json from ^0.20.0 to ^1.0.0. However, this major version upgrade introduces critical breaking changes in argument signatures and return types that will break the implementation in apps/kubernetes-provider/src/index.ts. These API usages must be updated to accommodate the new version before merging.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "license": "MIT", | ||
| "dependencies": { | ||
| "@kubernetes/client-node": "^0.20.0", | ||
| "@kubernetes/client-node": "^1.0.0", |
There was a problem hiding this comment.
Upgrading @kubernetes/client-node to 1.0.0 introduces major breaking changes that will break apps/kubernetes-provider/src/index.ts both at compile-time and runtime.
Breaking Changes:
- Argument Signature Changes:
In1.0.0, the generated API clients use a single object parameter instead of positional arguments. For example:
createNamespacedPod(namespace.metadata.name, pod)(line 624) needs to be updated tocreateNamespacedPod({ namespace: namespace.metadata.name, body: pod }).deleteNamespacedPod(opts.runId, opts.namespace.metadata.name)(line 633) needs to be updated todeleteNamespacedPod({ name: opts.runId, namespace: opts.namespace.metadata.name }).readNamespacedPod(runId, namespace.metadata.name)(line 645) needs to be updated toreadNamespacedPod({ name: runId, namespace: namespace.metadata.name }).createNamespacedJob(namespace.metadata.name, job)(line 655) needs to be updated tocreateNamespacedJob({ namespace: namespace.metadata.name, body: job }).createNamespacedDaemonSet(namespace.metadata.name, daemonSet)(line 664) needs to be updated tocreateNamespacedDaemonSet({ namespace: namespace.metadata.name, body: daemonSet }).
- Return Type Changes:
In1.0.0, API methods return the resource body directly instead of an object containing{ response, body }.
- Accessing
res.body(e.g.,logger.debug(res.body)orreturn res.body) will fail or returnundefined. You should useresdirectly.
Please update apps/kubernetes-provider/src/index.ts to accommodate these breaking changes before merging this upgrade.
2 participants
Snyk has created this PR to fix 2 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
apps/kubernetes-provider/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-QS-15268416
SNYK-JS-QS-16721866
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling
🦉 NULL Pointer Dereference
This change is