Skip to content

Commit 757615a

Browse files
committed
DYN-9702: Log when shared definitions folder is missing
Add a Trace.TraceWarning in PathManager.DefinitionDirectories when the common "definitions" folder (containing Curve_Validate.dyf, copied by DynamoCore.csproj at build time) is not found at commonDataDir. This is diagnostic-only -- the returned directory list is unchanged, and we deliberately do not auto-create the folder (that approach was tried and reverted). Previously this case failed completely silently, which caused a hard-to-diagnose CI regression. PathManager has no injected logger, so this follows the existing Trace-based diagnostic convention used elsewhere in the codebase for logger-less, non-fatal issues rather than adding a new logging dependency.
1 parent 1875d20 commit 757615a

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/DynamoCore/Configuration/PathManager.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,12 @@ public IEnumerable<string> DefinitionDirectories
225225
{
226226
definitionDirectories.Add(commonDefinitionsDirectory);
227227
}
228+
else if (!Directory.Exists(commonDefinitionsDirectory))
229+
{
230+
// Diagnostic only: log the missing shared definitions folder so the omission
231+
// is visible. Does not change the returned directories.
232+
Trace.TraceWarning("Expected shared definitions folder not found at: " + commonDefinitionsDirectory);
233+
}
228234

229235
return definitionDirectories;
230236
}

0 commit comments

Comments
 (0)