DYN-9702: Log when shared definitions folder is missing

Add a Trace.TraceWarning in PathManager.DefinitionDirectories when the
common "definitions" folder (containing Curve_Validate.dyf, copied by
DynamoCore.csproj at build time) is not found at commonDataDir. This
is diagnostic-only -- the returned directory list is unchanged, and we
deliberately do not auto-create the folder (that approach was tried
and reverted). Previously this case failed completely silently, which
caused a hard-to-diagnose CI regression. PathManager has no injected
logger, so this follows the existing Trace-based diagnostic convention
used elsewhere in the codebase for logger-less, non-fatal issues
rather than adding a new logging dependency.

Author: jasonstratton

src/DynamoCore/Configuration/PathManager.cs

@@ -225,6 +225,17 @@ public IEnumerable<string> DefinitionDirectories
                 {
                     definitionDirectories.Add(commonDefinitionsDirectory);
                 }
+                else if (!Directory.Exists(commonDefinitionsDirectory))
+                {
+                    // Diagnostic only: the shared "definitions" folder (e.g. Curve_Validate.dyf)
+                    // is expected to be copied next to DynamoCore.dll at build time (see the
+                    // Copy targets in DynamoCore.csproj). If it's missing, do not fabricate or
+                    // add the path here -- just make the omission visible so this doesn't fail
+                    // silently again (DYN-9702). PathManager has no injected logger, so this
+                    // follows the existing low-level Trace-based diagnostic convention used
+                    // elsewhere in DynamoCore instead of adding a new logging dependency.
+                    Trace.TraceWarning("Expected shared definitions folder not found at: " + commonDefinitionsDirectory);
+                }
 
                 return definitionDirectories;
             }