update test

Author: kalunkuo

src/Libraries/CoreNodes/Data.cs

@@ -666,7 +666,6 @@ public static object SafeExtractDictionaryValue(Dictionary<string, object> dict,
         public static Dictionary<string, object> EvaluateDefineDataNode([ArbitraryDimensionArrayImport] object inputValue,
             string typeString, bool isList, bool isAutoMode, string playerValue)
         {
-
             if (inputValue == null && string.IsNullOrEmpty(playerValue))
             {
                 // Don't raise a warning if the node is unused
@@ -677,6 +676,18 @@ public static Dictionary<string, object> EvaluateDefineDataNode([ArbitraryDimens
                 };
             }
 
+            // Unconnected var[]..[] ports can receive an empty sequence default.
+            if (string.IsNullOrEmpty(playerValue)
+                && inputValue is IEnumerable enumerable and not string
+                && !enumerable.Cast<object>().Any())
+            {
+                return new Dictionary<string, object>
+                {
+                    { ">", inputValue },
+                    { "Validation", null }
+                };
+            }
+
             // If the playerValue is not empty, then we assume it was set by the player.
             // In that case, we need to parse it to get the actual value replace the inputValue.
             if (!string.IsNullOrEmpty(playerValue))
@@ -694,6 +705,17 @@ public static Dictionary<string, object> EvaluateDefineDataNode([ArbitraryDimens
                 }
             }
 
+            // A player value can deserialize to null (e.g. "null"), which should
+            // follow the same behavior as an unused Define Data input.
+            if (inputValue == null)
+            {
+                return new Dictionary<string, object>
+                {
+                    { ">", inputValue },
+                    { "Validation", null }
+                };
+            }
+
             if (!IsSingleValueOrSingleLevelArrayList(inputValue))
             {
                 var warning = Properties.Resources.DefineDataSupportedInputValueExceptionMessage;
@@ -714,7 +736,16 @@ public static Dictionary<string, object> EvaluateDefineDataNode([ArbitraryDimens
                 // Type logic - we try to 'guess' the type of the object
                 if (type == null || !IsSupportedDataNodeDynamoType(inputValue, type.Type, assertList))
                 {
-                    var valueType = assertList ? FindCommonAncestor(arrayList) : inputValue.GetType();
+                    var valueType = assertList ? FindCommonAncestor(arrayList) : inputValue?.GetType();
+                    if (!assertList && valueType == null)
+                    {
+                        // Defensive null-safe fallback for analyzers: no input means no validation result.
+                        return new Dictionary<string, object>
+                        {
+                            { ">", inputValue },
+                            { "Validation", null }
+                        };
+                    }
                     if (valueType == null)
                     {
                         // We couldn't find a common ancestor - list containing unsupported or incompatible data types

test/DynamoCoreTests/DSCoreDataTests.cs

@@ -920,6 +920,17 @@ public void EvaluateDefineDataNodeReturnsNullWhenInputValueAndPlayerValueAreEmpt
             Assert.IsNull(result["Validation"]);
         }
 
+        [Test]
+        [Category("UnitTests")]
+        public void EvaluateDefineDataNodeReturnsNullWhenPlayerValueDeserializesToNull()
+        {
+            var booleanString = typeof(bool).ToString();
+            var result = DSCore.Data.EvaluateDefineDataNode(null, booleanString, false, true, "null");
+
+            Assert.IsNull(result[">"]);
+            Assert.IsNull(result["Validation"]);
+        }
+
         [Test]
         [Category("UnitTests")]
         public void ThrowsCorrectErrorTypes()

test/DynamoCoreTests/Nodes/DefineDataTests.cs

@@ -1,6 +1,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using CoreNodeModels;
+using Dynamo.Graph.Connectors;
 using Dynamo.Graph.Nodes;
 using NUnit.Framework;
 
@@ -92,7 +93,7 @@ public void WhenConnectedThenClearsMissingUpstreamConnectionInfo()
 
             CurrentDynamoModel.NodeFactory.CreateNodeFromTypeName("CoreNodeModels.Input.DoubleInput", out NodeModel numberNode);
             CurrentDynamoModel.CurrentWorkspace.AddAndRegisterNode(numberNode, false);
-            defineData.ConnectInput(0, 0, numberNode);
+            ConnectorModel.Make(numberNode, defineData, 0, 0);
 
             Assert.IsFalse(defineData.Infos.Any(x => x.State == ElementState.PersistentInfo));
         }