DYN-9663 fix missing parameter DataType in NodeDocumentationMarkdownGenerator (#17141)

johnpierson · claude · web-flow · commit d1661a7bb60b · 2026-06-12T11:09:23.000-04:00
Co-authored-by: Claude Sonnet 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/DocumentationBrowserViewExtension/NodeDocumentationHtmlGenerator.cs b/src/DocumentationBrowserViewExtension/NodeDocumentationHtmlGenerator.cs
@@ -268,7 +268,7 @@ private static string CreateInputsAndOutputs(OpenNodeAnnotationEventArgs e)
             {
                 sb.AppendLine("<tr class=\"table--border\">");
                 sb.AppendLine($"<td class=\"table--border\">{e.InputNames.ElementAt(i)}</td>");
-                sb.AppendLine($"<td class=\"table--border\">{GetTypeFromDescription(e.InputDescriptions.ElementAt(i))}</td>");
+                sb.AppendLine($"<td class=\"table--border\">{e.InputTypes.ElementAt(i)}</td>");
                 sb.AppendLine($"<td class=\"table--border\">{GetNthRowFromStringSplit(e.InputDescriptions.ElementAt(i), 0)}</td>");
                 sb.AppendLine($"<td class=\"table--border broken\">{GetDefaultValueFromDescription(e.InputDescriptions.ElementAt(i))}</td>");
                 sb.AppendLine(@"</tr>");
@@ -292,6 +292,7 @@ private static string CreateInputsAndOutputs(OpenNodeAnnotationEventArgs e)
                 sb.AppendLine(" <tr class=\"table--border\">");
                 sb.AppendLine($"<td class=\"table--border\">{e.OutputNames.ElementAt(i)}</td>");
                 sb.AppendLine($"<td class=\"table--border\">{GetNthRowFromStringSplit(e.OutputDescriptions.ElementAt(i), 0)}</td>");
+                sb.AppendLine($"<td class=\"table--border\">{e.OutputTypes.ElementAt(i)}</td>");
                 sb.AppendLine(@"</tr>");
             }
 
@@ -302,13 +303,6 @@ private static string CreateInputsAndOutputs(OpenNodeAnnotationEventArgs e)
             return sb.ToString();
         }
 
-         private static string GetTypeFromDescription(string element)
-         {
-             var stringArr = element.Split(new string[] {"\r\n", "\r", "\n"}, StringSplitOptions.None);
-             if(stringArr.Length > 2) return stringArr[2];
-             return string.Empty;
-         }
-
          private static string GetDefaultValueFromDescription(string element)
          {
              var stringArr = element.Split(new string[] { "\r\n", "\r", "\n" }, StringSplitOptions.None);
diff --git a/src/DynamoCore/Graph/Nodes/PortModel.cs b/src/DynamoCore/Graph/Nodes/PortModel.cs
@@ -515,12 +515,23 @@ internal string GetInputPortType()
 
                 try
                 {
-                    return inPortAttribute?.PortTypes.ElementAt(Index);
+                    var attrType = inPortAttribute?.PortTypes.ElementAt(Index);
+                    if (attrType != null) return attrType;
                 }
                 catch (Exception e)
                 {
                     Log(e.Message);
                 }
+
+                // Fallback: infer from the port's default value node type.
+                return DefaultValue switch
+                {
+                    IntNode     _ => "int",
+                    DoubleNode  _ => "double",
+                    BooleanNode _ => "bool",
+                    StringNode  _ => "string",
+                    _ => null
+                };
             }
             return null;
         }
diff --git a/src/DynamoCoreWpf/PublicAPI.Unshipped.txt b/src/DynamoCoreWpf/PublicAPI.Unshipped.txt
@@ -26,6 +26,8 @@ Dynamo.ViewModels.DynamoViewModel.PythonEngineUpgradeToastRequested -> System.Ac
 Dynamo.ViewModels.DynamoViewModel.ToastManager.get -> Dynamo.Wpf.UI.ToastManager
 Dynamo.ViewModels.DynamoViewModel.ToastManager.set -> void
 Dynamo.ViewModels.DynamoViewModel.ShowPythonEngineUpgradeCanvasToast(string message, bool stayOpen = true, string filePath = null) -> void
+Dynamo.ViewModels.OpenNodeAnnotationEventArgs.InputTypes.get -> System.Collections.Generic.IEnumerable<string>
+Dynamo.ViewModels.OpenNodeAnnotationEventArgs.OutputTypes.get -> System.Collections.Generic.IEnumerable<string>
 Dynamo.ViewModels.PreferencesViewModel.AutoSyncDocumentBrowserIsChecked.get -> bool
 Dynamo.ViewModels.PreferencesViewModel.AutoSyncDocumentBrowserIsChecked.set -> void
 Dynamo.ViewModels.PreferencesViewModel.ShowPythonAutoMigrationNotificationIsChecked.get -> bool
diff --git a/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModelEventArgs.cs b/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModelEventArgs.cs
@@ -217,6 +217,14 @@ public class OpenNodeAnnotationEventArgs : OpenDocumentationLinkEventArgs
         /// </summary>
         public IEnumerable<string> OutputDescriptions { get; private set; }
         /// <summary>
+        /// Collection of the nodes input port types.
+        /// </summary>
+        public IEnumerable<string> InputTypes { get; private set; }
+        /// <summary>
+        /// Collection of the nodes output port types.
+        /// </summary>
+        public IEnumerable<string> OutputTypes { get; private set; }
+        /// <summary>
         /// Collection of the nodes collection of warnings/errors/infos.
         /// </summary>
         public IEnumerable<Info> NodeInfos { get; private set; }
@@ -247,33 +255,38 @@ private void SetOutputs(NodeModel nodeModel)
         {
             var outputNames = new List<string>();
             var outputDescriptions = new List<string>();
+            var outputTypes = new List<string>();
 
             var outputs = nodeModel.OutPorts;
             foreach (var output in outputs)
             {
                 outputNames.Add(output.Name);
                 outputDescriptions.Add(output.ToolTip);
+                outputTypes.Add(output.GetOutPortType() ?? string.Empty);
             }
 
             OutputNames = outputNames;
             OutputDescriptions = outputDescriptions;
+            OutputTypes = outputTypes;
         }
 
         private void SetInputs(NodeModel nodeModel)
         {
             var inputNames = new List<string>();
             var inputDescriptions = new List<string>();
+            var inputTypes = new List<string>();
 
             var inputs = nodeModel.InPorts;
             foreach (var input in inputs)
             {
                 inputNames.Add(input.Name);
                 inputDescriptions.Add(input.ToolTip);
+                inputTypes.Add(input.GetInputPortType() ?? string.Empty);
             }
 
             InputNames = inputNames;
             InputDescriptions = inputDescriptions;
-
+            InputTypes = inputTypes;
         }
     }
 
diff --git a/src/Tools/NodeDocumentationMarkdownGenerator/AssemblyHandler.cs b/src/Tools/NodeDocumentationMarkdownGenerator/AssemblyHandler.cs
@@ -422,7 +422,7 @@ private static List<TypedParameter> BuildParameters(ArgumentSignatureNode signat
                     }
                 }
 
-                typeParams.Add(new TypedParameter(name));
+                typeParams.Add(new TypedParameter(name, arg.ArgumentType));
             }
 
             return typeParams;
diff --git a/test/DynamoCoreWpf3Tests/NodeViewTests.cs b/test/DynamoCoreWpf3Tests/NodeViewTests.cs
@@ -9,19 +9,32 @@
 using System.Windows.Media;
 using Dynamo.Controls;
 using Dynamo.Graph;
+using Dynamo.Graph.Nodes;
 using Dynamo.Graph.Workspaces;
 using Dynamo.Models;
 using Dynamo.Selection;
 using Dynamo.UI.Prompts;
 using Dynamo.ViewModels;
 using DynamoCoreWpfTests.Utility;
 using NUnit.Framework;
+using ProtoCore.AST.AssociativeAST;
 
 namespace DynamoCoreWpfTests
 {
     public class NodeViewTests : DynamoTestUIBase
     {
         // adapted from: http://stackoverflow.com/questions/9336165/correct-method-for-using-the-wpf-dispatcher-in-unit-tests
+        private class DefaultValueInputTypeNode : NodeModel
+        {
+            internal DefaultValueInputTypeNode()
+            {
+                InPorts.Add(new PortModel(PortType.Input, this, new PortData("integer", "integer", AstFactory.BuildIntNode(1))));
+                InPorts.Add(new PortModel(PortType.Input, this, new PortData("number", "number", AstFactory.BuildDoubleNode(1.0))));
+                InPorts.Add(new PortModel(PortType.Input, this, new PortData("boolean", "boolean", AstFactory.BuildBooleanNode(true))));
+                InPorts.Add(new PortModel(PortType.Input, this, new PortData("text", "text", AstFactory.BuildStringNode("value"))));
+                RegisterAllPorts();
+            }
+        }
 
         protected override void GetLibrariesToPreload(List<string> libraries)
         {
@@ -361,6 +374,16 @@ public void InputPortType_NodeModelNode_AreCorrect()
             Assert.AreEqual("System.Drawing.Bitmap", type);
         }
 
+        [Test]
+        public void InputPortType_NodeModelNodeWithoutInPortTypes_FallsBackToDefaultValueType()
+        {
+            var node = new DefaultValueInputTypeNode();
+
+            CollectionAssert.AreEqual(
+                new[] { "int", "double", "bool", "string" },
+                node.InPorts.Select(port => port.GetInputPortType()));
+        }
+
         [Test]
         [Category("RegressionTests")]
         public void GettingNodeNameDoesNotTriggerPropertyChangeCycle()

Original file line number	Diff line number	Diff line change
`@@ -515,12 +515,23 @@ internal string GetInputPortType()`
`515`	`515`
`516`	`516`	`try`
`517`	`517`	`{`
`518`		`- return inPortAttribute?.PortTypes.ElementAt(Index);`
	`518`	`+ var attrType = inPortAttribute?.PortTypes.ElementAt(Index);`
	`519`	`+ if (attrType != null) return attrType;`
`519`	`520`	`}`
`520`	`521`	`catch (Exception e)`
`521`	`522`	`{`
`522`	`523`	`Log(e.Message);`
`523`	`524`	`}`
	`525`	`+`
	`526`	`+ // Fallback: infer from the port's default value node type.`
	`527`	`+ return DefaultValue switch`
	`528`	`+ {`
	`529`	`+ IntNode _ => "int",`
	`530`	`+ DoubleNode _ => "double",`
	`531`	`+ BooleanNode _ => "bool",`
	`532`	`+ StringNode _ => "string",`
	`533`	`+ _ => null`
	`534`	`+ };`
`524`	`535`	`}`
`525`	`536`	`return null;`
`526`	`537`	`}`
Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,14 @@ public class OpenNodeAnnotationEventArgs : OpenDocumentationLinkEventArgs`
`217`	`217`	`/// </summary>`
`218`	`218`	`public IEnumerable<string> OutputDescriptions { get; private set; }`
`219`	`219`	`/// <summary>`
	`220`	`+ /// Collection of the nodes input port types.`
	`221`	`+ /// </summary>`
	`222`	`+ public IEnumerable<string> InputTypes { get; private set; }`
	`223`	`+ /// <summary>`
	`224`	`+ /// Collection of the nodes output port types.`
	`225`	`+ /// </summary>`
	`226`	`+ public IEnumerable<string> OutputTypes { get; private set; }`
	`227`	`+ /// <summary>`
`220`	`228`	`/// Collection of the nodes collection of warnings/errors/infos.`
`221`	`229`	`/// </summary>`
`222`	`230`	`public IEnumerable<Info> NodeInfos { get; private set; }`
`@@ -247,33 +255,38 @@ private void SetOutputs(NodeModel nodeModel)`
`247`	`255`	`{`
`248`	`256`	`var outputNames = new List<string>();`
`249`	`257`	`var outputDescriptions = new List<string>();`
	`258`	`+ var outputTypes = new List<string>();`
`250`	`259`
`251`	`260`	`var outputs = nodeModel.OutPorts;`
`252`	`261`	`foreach (var output in outputs)`
`253`	`262`	`{`
`254`	`263`	`outputNames.Add(output.Name);`
`255`	`264`	`outputDescriptions.Add(output.ToolTip);`
	`265`	`+ outputTypes.Add(output.GetOutPortType() ?? string.Empty);`
`256`	`266`	`}`
`257`	`267`
`258`	`268`	`OutputNames = outputNames;`
`259`	`269`	`OutputDescriptions = outputDescriptions;`
	`270`	`+ OutputTypes = outputTypes;`
`260`	`271`	`}`
`261`	`272`
`262`	`273`	`private void SetInputs(NodeModel nodeModel)`
`263`	`274`	`{`
`264`	`275`	`var inputNames = new List<string>();`
`265`	`276`	`var inputDescriptions = new List<string>();`
	`277`	`+ var inputTypes = new List<string>();`
`266`	`278`
`267`	`279`	`var inputs = nodeModel.InPorts;`
`268`	`280`	`foreach (var input in inputs)`
`269`	`281`	`{`
`270`	`282`	`inputNames.Add(input.Name);`
`271`	`283`	`inputDescriptions.Add(input.ToolTip);`
	`284`	`+ inputTypes.Add(input.GetInputPortType() ?? string.Empty);`
`272`	`285`	`}`
`273`	`286`
`274`	`287`	`InputNames = inputNames;`
`275`	`288`	`InputDescriptions = inputDescriptions;`
`276`		`-`
	`289`	`+ InputTypes = inputTypes;`
`277`	`290`	`}`
`278`	`291`	`}`
`279`	`292`
Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ private static List<TypedParameter> BuildParameters(ArgumentSignatureNode signat`
`422`	`422`	`}`
`423`	`423`	`}`
`424`	`424`
`425`		`- typeParams.Add(new TypedParameter(name));`
	`425`	`+ typeParams.Add(new TypedParameter(name, arg.ArgumentType));`
`426`	`426`	`}`
`427`	`427`
`428`	`428`	`return typeParams;`