DYN-10279 Add workflow - validate-skills (#16961)

Co-authored-by: Aaron (Qilong) <173288704@qq.com>

Author: avidit

.agents/README.md

@@ -15,13 +15,13 @@ Use the wrapper sync script to keep `.github/agents/` aligned with canonical ski
 
 ```powershell
 # Regenerate wrappers from canonical skills
-./tools/agents/sync-agent-wrappers.ps1
+./.github/scripts/sync_agent_wrappers.ps1
 
 # Validate wrappers are in sync (non-zero exit code on drift)
-./tools/agents/sync-agent-wrappers.ps1 -Check
+./.github/scripts/sync_agent_wrappers.ps1 -Check
 
 # Print a compact diagnostics summary (does not change pass/fail)
-./tools/agents/sync-agent-wrappers.ps1 -Check -VerboseReport
+./.github/scripts/sync_agent_wrappers.ps1 -Check -VerboseReport
 ```
 
 Check mode validates:
@@ -43,7 +43,7 @@ This matrix documents how canonical skills in `.agents/skills/` are exposed in e
 
 Notes:
 - Skill logic lives only in `.agents/skills/`.
-- Copilot wrappers are generated/validated by `tools/agents/sync-agent-wrappers.ps1`.
+- Copilot wrappers are generated/validated by `.github/scripts/sync_agent_wrappers.ps1`.
 - If mirrors differ from canonical files, canonical files win.
 
 ## Quick Reference
@@ -86,16 +86,19 @@ Templates are co-located inside the skill folder that uses them:
 │   ├── dynamo-onboarding/
 │   │   └── SKILL.md
 │   ├── dynamo-pr-description/
-│   │   ├── SKILL.md          ← workflow for writing PR descriptions
+│   │   └── SKILL.md
 │   ├── dynamo-jira-ticket/
-│   │   ├── SKILL.md          ← workflow for writing Jira tickets
-│   │   └── template.md       ← copy/paste Jira template
+│   │   ├── SKILL.md
+│   │   └── assets/
+│   │       └── template.md       ← copy/paste Jira template
 │   ├── dynamo-skill-writer/
-│   │   └── SKILL.md          ← workflow for authoring and syncing skills
+│   │   └── SKILL.md
 │   └── dynamo-unit-testing/
-│       ├── SKILL.md          ← workflow for writing tests
-│       ├── test-patterns.md  ← code templates & examples
-│       └── quality-checklist.md  ← guidelines & best practices
+│       ├── SKILL.md
+│       ├── assets/
+│       │   └── test-patterns.md     ← code templates & examples
+│       └── references/
+│           └── quality-checklist.md ← guidelines & best practices
 ├── rules/
 │   └── dynamo-core-rules.md
 └── README.md                  ← you are here

.agents/skills/dynamo-dotnet-expert/SKILL.md

@@ -3,7 +3,7 @@ name: dynamo-dotnet-expert
 description: Write and review C#/.NET code in Dynamo following Dynamo coding standards, modern C# patterns, and repo conventions. Use this skill whenever writing C# code, reviewing a PR diff, designing types, managing PublicAPI surface files, choosing patterns, making performance decisions, or refactoring in the Dynamo codebase. Also use when asking about NUnit testing, async patterns, error handling, immutability, or security in Dynamo.
 ---
 
-# Dynamo .NET Expert
+# Dynamo dotNet Expert
 
 ## When to use
 

.agents/skills/dynamo-jira-ticket/SKILL.md

@@ -3,7 +3,7 @@ name: dynamo-jira-ticket
 description: Create structured Jira tickets for Dynamo from bug reports, failing tests, or feature requests. Use this skill whenever writing a Jira ticket, triaging a bug, turning a vague issue into an actionable ticket, or writing acceptance criteria. Also use when the user mentions "file a ticket", "write a bug report", or "create a Jira issue" for Dynamo.
 ---
 
-# Dynamo Jira Ticket Writer
+# Dynamo Jira Ticket
 
 ## When to use
 
@@ -22,7 +22,7 @@ A bug description, error log, failing test output, feature request, or code inve
 
 ## Output format
 
-A complete Jira ticket body ready to paste, following the canonical template in `template.md`.
+A complete Jira ticket body ready to paste, following the canonical template in [template](./assets/template.md).
 
 ---
 
@@ -34,7 +34,7 @@ A complete Jira ticket body ready to paste, following the canonical template in
    - For UI issues: check `src/DynamoCoreWpf/` and the relevant view extension.
    - For PublicAPI errors: check `PublicAPI.Unshipped.txt` / `PublicAPI.Shipped.txt` in the affected project.
    - For test failures: read the NUnit test output and the relevant test file.
-2. **Write the ticket** using `template.md` in this folder.
+2. **Write the ticket** using `./assets/template.md` in this folder.
 3. **Review** -- ensure every section has concrete, verifiable content. No vague language.
 
 ## Writing Rules
@@ -47,7 +47,7 @@ A complete Jira ticket body ready to paste, following the canonical template in
 
 ## Ticket Template
 
-Use the canonical template at `template.md` in this folder.
+Use the canonical template at `./assets/template.md` in this folder.
 
 Required sections in each generated ticket:
 - Title

…ts/skills/dynamo-jira-ticket/template.md …ls/dynamo-jira-ticket/assets/template.md.agents/skills/dynamo-jira-ticket/template.md renamed to .agents/skills/dynamo-jira-ticket/assets/template.md .agents/skills/dynamo-jira-ticket/template.md renamed to .agents/skills/dynamo-jira-ticket/assets/template.md

@@ -3,7 +3,7 @@ name: dynamo-pr-description
 description: Generate PR descriptions for Dynamo that align with the team template section names and order. Use this skill whenever writing a pull request description, cleaning up a PR body, or generating a review-ready summary from a diff in the Dynamo repo. Also use when the user says "write a PR", "PR description", or "prep this for review."
 ---
 
-# Dynamo PR Description Writer
+# Dynamo PR Description
 
 ## When to use
 
@@ -14,7 +14,7 @@ description: Generate PR descriptions for Dynamo that align with the team templa
 ## When not to use
 
 - PRs targeting the DynamoMCP repo -- that repo has its own PR description skill.
-- Jira ticket triage -- use [template](../dynamo-jira-ticket/template.md) instead.
+- Jira ticket triage -- use [template](../dynamo-jira-ticket/assets/template.md) instead.
 
 ## Inputs expected
 

.agents/skills/dynamo-pr-description/SKILL.md

@@ -25,7 +25,7 @@ A request to add/update a skill, or a request to sync skill surfaces across Copi
 
 A concrete set of file edits and validation steps that:
 - updates canonical skill content in `.agents/skills/`
-- updates sync metadata in `tools/agents/sync-agent-wrappers.ps1` when Copilot exposure is needed
+- updates sync metadata in `.github/scripts/sync_agent_wrappers.ps1` when Copilot exposure is needed
 - regenerates and validates wrappers in `.github/agents/`
 - updates index/docs references in `.agents/README.md`, `.github/copilot-instructions.md`, and `CLAUDE.md` when applicable
 
@@ -35,11 +35,11 @@ A concrete set of file edits and validation steps that:
 
 1. Determine whether this is a **new skill** or an **update to an existing skill**.
 2. Author or update canonical content in `.agents/skills/<skill-name>/SKILL.md`.
-3. If the skill should be available as a Copilot agent, add an entry to the wrapper map in `tools/agents/sync-agent-wrappers.ps1`.
+3. If the skill should be available as a Copilot agent, add an entry to the `canonicalSkills` array in `.github/scripts/sync_agent_wrappers.ps1`.
 4. Regenerate wrappers:
-   - `./tools/agents/sync-agent-wrappers.ps1`
+   - `./.github/scripts/sync_agent_wrappers.ps1`
 5. Validate sync:
-   - `./tools/agents/sync-agent-wrappers.ps1 -Check -VerboseReport`
+   - `./.github/scripts/sync_agent_wrappers.ps1 -Check -VerboseReport`
 6. Update discovery docs when skill inventory changed:
    - `.agents/README.md`
    - `.github/copilot-instructions.md`
@@ -59,9 +59,9 @@ A concrete set of file edits and validation steps that:
 - [ ] Created `.agents/skills/<skill-name>/SKILL.md` with frontmatter (`name`, `description`)
 - [ ] Added skill to `.agents/README.md` Quick Reference table
 - [ ] Added skill to `.agents/README.md` parity matrix (if cross-tool surfaced)
-- [ ] Added skill to `tools/agents/sync-agent-wrappers.ps1` wrapper map (if Copilot surfaced)
+- [ ] Added skill to `.github/scripts/sync_agent_wrappers.ps1` wrapper map (if Copilot surfaced)
 - [ ] Regenerated `.github/agents/*` wrappers
-- [ ] Ran `./tools/agents/sync-agent-wrappers.ps1 -Check -VerboseReport`
+- [ ] Ran `./.github/scripts/sync_agent_wrappers.ps1 -Check -VerboseReport`
 - [ ] Updated `.github/copilot-instructions.md` skill list
 - [ ] Updated `CLAUDE.md` skill list
 

.agents/skills/dynamo-skill-writer/SKILL.md

@@ -28,7 +28,7 @@ Complete test classes with proper setup, test methods using Dynamo patterns, and
 
 ## Workflow
 
-> 🚀 **Quick Start**: [test-patterns.md](test-patterns.md) has ready-to-use templates
+> 🚀 **Quick Start**: [test-patterns.md](./assets/test-patterns.md) has ready-to-use templates
 
 ### 1. Choose Your Base Class
 Select the appropriate test base class based on what you're testing:
@@ -37,7 +37,6 @@ Select the appropriate test base class based on what you're testing:
 - **DSEvaluationUnitTestBase** - DesignScript expression evaluation
 
 ### 2. Apply Testing Standards
-Follow NUnit conventions and Dynamo patterns. See [quality-checklist.md](quality-checklist.md) for guidelines and anti-patterns and Dynamo coding standards for general coding practices.
 - [Dynamo Coding Standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)
 - [Dynamo Naming Standards](https://github.com/DynamoDS/Dynamo/wiki/Naming-Standards)
 
@@ -53,8 +52,8 @@ One behavior per test, descriptive names, Arrange-Act-Assert structure.
 ## Documentation
 
 **Assets & References:**
-- **[test-patterns.md](test-patterns.md)** - Base classes, code templates, common scenarios, complete examples
-- **[quality-checklist.md](quality-checklist.md)** - Quality guidelines, anti-patterns, best practices
+- **[test-patterns.md](./assets/test-patterns.md)** - Base classes, code templates, common scenarios, complete examples
+- **[quality-checklist.md](./references/quality-checklist.md)** - Quality guidelines, anti-patterns, best practices
 
 **Related Skills:**
 [dynamo-dotnet-expert](../dynamo-dotnet-expert/SKILL.md) • [dynamo-onboarding](../dynamo-onboarding/SKILL.md)