DYN-8977 Fix git actions#16260
Merged
Merged
Conversation
avidit
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8977
avidit
reviewed
Jun 3, 2025
pinzart90
changed the title
mjkkirschner
reviewed
Jun 3, 2025
| uses: microsoft/setup-msbuild@v2 | ||
| - name: Install dependencies for windows runtime | ||
| run: | | ||
| dotnet restore ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64 -p:DotNet=net8.0 |
Member
There was a problem hiding this comment.
no memory of this - any idea what we were trying to accomplish with this?
by this I mean p:DotNet=net8.0
Contributor
There was a problem hiding this comment.
zeusongit
approved these changes
Jun 3, 2025
avidit
approved these changes
Jun 3, 2025
Contributor
|
Building dynamo locally now gives the following error: |
Contributor
Author
Yeah, I forgot to mention that the fix is specific to the dotnet version in the git build machines. Maybe we can specify major.minor without patch in the global config. |
Contributor
Author
|
I am not able to look into it now. I would bet that the internal cicd jobs might fail too, if they do not have that specific version of s dotnet sdk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix git actions
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of