Skip to content

DYN-8977 Create global.json dynamically #16266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeusongit merged 5 commits into from
Jun 4, 2025
Merged

DYN-8977 Create global.json dynamically #16266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0770fbd
DYN-8977 Create global.json dynamically
avidit Jun 4, 2025
bf44482
Update
avidit Jun 4, 2025
94e7be3
Update
avidit Jun 4, 2025
48c64f8
Update
avidit Jun 4, 2025
16b5d72
Update
avidit Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/build_dynamo_all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,18 @@ jobs:
with:
path: Dynamo
repository: DynamoDS/Dynamo
- name: Create global.json
run: |
$globalJson = @"
{
"projects": ["src", "test"],

@pinzart90 pinzart90 Jun 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this do anything ?

@pinzart90 pinzart90 Jun 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see it mentioned in the docs https://learn.microsoft.com/en-us/dotnet/core/tools/global-json

@avidit avidit Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with projects array, global.json applies to all projects in the folders which avoids the need of adding it in different places.

"sdk": {
"version": "8.0.100",
"rollForward": "latestFeature"
}
}
"@
$globalJson | Out-File -FilePath ${{ github.workspace }}\Dynamo\global.json -Encoding utf8

@pinzart90 pinzart90 Jun 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did the dotnet command not work for some reason?

@avidit avidit Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did, but I couldn't figure out how to add projects with dotnet add globalJson.
We could run dotnet add command twice (for src and test folders) or this.

- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
Expand Down
24 changes: 24 additions & 0 deletions .github/workflows/build_dynamo_core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,18 @@ jobs:
with:
path: Dynamo
repository: DynamoDS/Dynamo
- name: Create global.json
run: |
$globalJson = @"
{
"projects": ["src", "test"],
"sdk": {
"version": "8.0.100",
"rollForward": "latestFeature"
}
}
"@
$globalJson | Out-File -FilePath ${{ github.workspace }}\Dynamo\global.json -Encoding utf8
- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
Expand Down Expand Up @@ -47,6 +59,18 @@ jobs:
with:
path: Dynamo
repository: DynamoDS/Dynamo
- name: Create global.json
run: |
$globalJson = @"
{
"projects": ["src", "test"],
"sdk": {
"version": "8.0.100",
"rollForward": "latestFeature"
}
}
"@
$globalJson | Out-File -FilePath ${{ github.workspace }}\Dynamo\global.json -Encoding utf8
- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
Expand Down
38 changes: 28 additions & 10 deletions .github/workflows/dynamo_bin_diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,18 @@ jobs:
with:
path: Dynamo
repository: DynamoDS/Dynamo
- name: Create global.json
run: |
$globalJson = @"
{
"projects": ["src", "test"],
"sdk": {
"version": "8.0.100",
"rollForward": "latestFeature"
}
}
"@
$globalJson | Out-File -FilePath ${{ github.workspace }}\Dynamo\global.json -Encoding utf8
- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
Expand All @@ -26,12 +38,9 @@ jobs:
- name: Setup msbuild
uses: microsoft/setup-msbuild@v2
- name: Install dependencies for windows runtime
run: |
dotnet restore ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64
run: dotnet restore ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64
- name: Build Dynamo with MSBuild
run: |
Write-Output "***Continue with the build, Good luck developer!***"
msbuild ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release
run: msbuild ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release
- name: Look for DynamoCLI.exe
run: |
Write-Output "***Locating DynamoCLI.exe!***"
Expand All @@ -57,6 +66,18 @@ jobs:
path: master
ref: master
repository: DynamoDS/Dynamo
- name: Create global.json
run: |
$globalJson = @"
{
"projects": ["src", "test"],
"sdk": {
"version": "8.0.100",
"rollForward": "latestFeature"
}
}
"@
$globalJson | Out-File -FilePath ${{ github.workspace }}\master\global.json -Encoding utf8
- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
Expand All @@ -66,12 +87,9 @@ jobs:
- name: Setup msbuild
uses: microsoft/setup-msbuild@v2
- name: Install dependencies for windows runtime
run: |
dotnet restore ${{ github.workspace }}\master\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64 -p:DotNet=net8.0
run: dotnet restore ${{ github.workspace }}\master\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64
- name: Build Dynamo with MSBuild

@aparajit-pratap aparajit-pratap Jun 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the -p:DotNet=net8.0 not used in the previous dotnet restore in line 41?

@avidit avidit Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinzart90 Correct me if I am wrong, I think we can remove it here as well, net8.0 is the default
https://github.com/DynamoDS/Dynamo/blob/master/src/Config/CS_SDK.props#L9

@pinzart90 pinzart90 Jun 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct

@zeusongit zeusongit Jun 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avidit can you make that change, and then we can merge

@avidit avidit Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

run: |
Write-Output "***Continue with the build, Good luck developer!***"
msbuild ${{ github.workspace }}\master\src\Dynamo.All.sln /p:Configuration=Release /p:DotNet=net8.0
run: msbuild ${{ github.workspace }}\master\src\Dynamo.All.sln /p:Configuration=Release
- name: Look for DynamoCLI.exe
run: |
Write-Output "***Locating DynamoCLI.exe!***"
Expand Down
5 changes: 0 additions & 5 deletions src/global.json
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions test/global.json
View file
Open in desktop

This file was deleted.

Loading