Skip to content

DYN-8953: Remove beta tag#16268

Merged
chubakueno merged 3 commits into
DynamoDS:masterfrom
chubakueno:feature/DYN-8953
Jun 5, 2025
Merged

DYN-8953: Remove beta tag#16268
chubakueno merged 3 commits into
DynamoDS:masterfrom
chubakueno:feature/DYN-8953

Conversation

@chubakueno

Copy link
Copy Markdown
Contributor

Purpose

Remove beta tag from preferences window.

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Remove beta tag from preferences window.

Reviewers

@johnpierson
@BogdanZavu

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8953

@QilongTang QilongTang requested a review from Copilot June 4, 2025 23:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the beta tag from the preferences window in Dynamo, in accordance with the update to deprecate the beta indicator.

  • Removed the Label control responsible for displaying the beta tag in the preferences view
  • Cleaned up associated XAML markup and styles linked to the beta tag
Comments suppressed due to low confidence (1)

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml:1010

  • The removal of the beta tag control looks correct, but ensure that any associated resource references (like p:Resources.PreferencesViewBetaTag) are also cleaned up if no longer used elsewhere.
-                                                <!--Beta tag-->

@QilongTang

Copy link
Copy Markdown
Contributor

Would you also remove the resource if unused after your change PreferencesViewBetaTag?

@BogdanZavu

Copy link
Copy Markdown
Contributor

Let's remove unused string and LGTM !

@johnpierson

Copy link
Copy Markdown
Member

relevant resource to remove:

<data name="PreferencesViewBetaTag" xml:space="preserve">
<value>Beta</value>
</data>

@chubakueno chubakueno merged commit f2ce342 into DynamoDS:master Jun 5, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants