DYN-8953: Remove beta tag#16268
Merged
Merged
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8953
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the beta tag from the preferences window in Dynamo, in accordance with the update to deprecate the beta indicator.
- Removed the Label control responsible for displaying the beta tag in the preferences view
- Cleaned up associated XAML markup and styles linked to the beta tag
Comments suppressed due to low confidence (1)
src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml:1010
- The removal of the beta tag control looks correct, but ensure that any associated resource references (like p:Resources.PreferencesViewBetaTag) are also cleaned up if no longer used elsewhere.
- <!--Beta tag-->
Contributor
|
Would you also remove the resource if unused after your change |
BogdanZavu
approved these changes
Jun 5, 2025
Contributor
|
Let's remove unused string and LGTM ! |
Member
|
relevant resource to remove: Dynamo/src/DynamoCoreWpf/Properties/Resources.resx Lines 3737 to 3739 in 8a4ec95 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove beta tag from preferences window.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Remove beta tag from preferences window.
Reviewers
@johnpierson
@BogdanZavu
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of