DYN-8789: hide DynamoToolTip when parent window is not visible#16269
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8789
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DynamoTextBox control to hide the DynamoToolTip popup when its parent window becomes not visible.
- Subscribes to the PlacementTarget's IsVisibleChanged event when the popup is opened
- Unsubscribes from the event when the popup is closed
- Closes the popup when the PlacementTarget is no longer visible
chubakueno
force-pushed
the
feature/DYN-8789
branch
2 times, most recently
from
8e7ef3c to
35e34d1
Compare
Contributor
Author
|
Fixed #16268 in the wrong branch, force pushed to undo. |
BogdanZavu
reviewed
Jun 5, 2025
| { | ||
| if (_target != null && !_target.IsVisible) | ||
| { | ||
| IsOpen = false; |
Contributor
There was a problem hiding this comment.
Maybe do the unsubscribe here as well and set target to null ?
Contributor
Author
There was a problem hiding this comment.
If we unsubscribe here, the popup will no longer resubscribe after the first disappearance, since tooltips are reused.
BogdanZavu
approved these changes
Jun 5, 2025
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Hide DynamoToolTip when parent window is not visible
2025-06-04.22-11-06.mp4
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Hide DynamoToolTip when parent window is not visible
Reviewers
@johnpierson
@BogdanZavu
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of