Skip to content

DYN-8943: Show node name for single autocomplete#16270

Merged
chubakueno merged 1 commit into
DynamoDS:masterfrom
chubakueno:feature/DYN-8943
Jun 5, 2025
Merged

DYN-8943: Show node name for single autocomplete#16270
chubakueno merged 1 commit into
DynamoDS:masterfrom
chubakueno:feature/DYN-8943

Conversation

@chubakueno

Copy link
Copy Markdown
Contributor

Purpose

Show node name for single autocomplete

2025-06-04.23-26-02.mp4

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Show node name for single autocomplete

Reviewers

@BogdanZavu
@johnpierson

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8943

@johnpierson johnpierson added the ai/ml 🧠 synapse team related PRs label Jun 5, 2025
@johnpierson johnpierson requested a review from Copilot June 5, 2025 12:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the single-item autocomplete dropdown to show the node’s name (instead of description) and its parameters, and fixes an issue with GUID generation.

  • Bind the Description text block to the node’s Name and append its Parameters
  • Added a Parameters property throughout the view models
  • Corrected Id generation from new Guid() to Guid.NewGuid()

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml Updated ComboBox item template to include a second Run for parameters next to the description
src/NodeAutoCompleteViewExtension/ViewModels/SingleResultItem.cs Changed Description mapping to use model.Name and added Parameters property
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs Fixed GUID generation and updated dropdown view model mapping to include Parameters and filter by confidence
src/NodeAutoCompleteViewExtension/ViewModels/DNADropdownViewModel.cs Added Parameters property for binding
Comments suppressed due to low confidence (3)

src/NodeAutoCompleteViewExtension/ViewModels/SingleResultItem.cs:13

  • [nitpick] The property Description is now being assigned the node’s name rather than its description, which can be misleading. Consider renaming this property (and its bindings) to Name or Title to accurately reflect its content.
Description = model.Name;

src/NodeAutoCompleteViewExtension/ViewModels/SingleResultItem.cs:32

  • Since you’ve introduced a new Parameters field that’s surfaced in the UI, consider adding unit tests for SingleResultItem and related view models to ensure Parameters is populated and rendered correctly.
internal string Parameters { get; set; }

src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml:201

  • [nitpick] The hardcoded color #abafb3 could be moved into a resource dictionary or style to centralize theming and simplify future updates.
<Run Text="{Binding Parameters, Mode=OneWay}" Foreground="#abafb3" />

@chubakueno chubakueno merged commit 3f99d6d into DynamoDS:master Jun 5, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai/ml 🧠 synapse team related PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants