Skip to content

DYN-8943: Show node name for single autocomplete #16270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubakueno merged 1 commit into from
Jun 5, 2025
Merged

DYN-8943: Show node name for single autocomplete #16270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/NodeAutoCompleteViewExtension/ViewModels/DNADropdownViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ namespace Dynamo.NodeAutoComplete.ViewModels
public class DNADropdownViewModel
{
public string Description { get; set; }
public string Parameters { get; set; }
public ImageSource SmallIcon { get; set; }
}
}
7 changes: 4 additions & 3 deletions src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,7 @@ internal void PopulateAutoComplete()
Topology = new TopologyItem
{
Nodes = new List<NodeItem> { new NodeItem {
Id = new Guid().ToString(),
Id = Guid.NewGuid().ToString(),
Type = new NodeType { Id = x.CreationName } } },
Connections = new List<ConnectionItem>()
}
Expand Down Expand Up @@ -1016,10 +1016,11 @@ internal void PopulateAutoComplete()
SearchViewModelRequestBitmapSource(iconRequest);
dict[singleResult.CreationName] = iconRequest.Icon;
}
comboboxResults = QualifiedResults.Select(x => new DNADropdownViewModel
comboboxResults = FullSingleResults.Where(x => x.Score * 100 > minClusterConfidenceScore).Select(x => new DNADropdownViewModel
{
Description = x.Description,
SmallIcon = dict[x.Topology.Nodes.First().Type.Id],
Parameters = x.Parameters,
SmallIcon = dict[x.CreationName],
});
}
else
Expand Down
5 changes: 4 additions & 1 deletion src/NodeAutoCompleteViewExtension/ViewModels/SingleResultItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ public SingleResultItem(NodeSearchElement model, double score = 1.0)
{
Assembly = model.Assembly;
IconName = model.IconName;
Description = model.Description;
Description = model.Name;
Parameters = model.Parameters;
CreationName = model.CreationName;
PortToConnect = model.AutoCompletionNodeElementInfo.PortToConnect;
Score = score;
Expand All @@ -28,6 +29,8 @@ public SingleResultItem(NodeSearchElementViewModel x) : this(x.Model)

internal string Description { get; set; }

internal string Parameters { get; set; }

internal string CreationName { get; set; }

internal int PortToConnect { get; set; }
Expand Down
7 changes: 6 additions & 1 deletion src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,12 @@
</Style>
</Image.Style>
</Image>
<TextBlock Text="{Binding Description}" FontSize="12" Foreground="White" Height="15"/>
<TextBlock FontSize="12" Height="15">
<Run Text="{Binding Description, Mode=OneWay}"
Foreground="White" />
<Run Text="{Binding Parameters, Mode=OneWay}"
Foreground="#abafb3" />
</TextBlock>
</StackPanel>
</DataTemplate>
</ComboBox.ItemTemplate>
Expand Down
Loading