Skip to content

Update build_dynamo_core.yml#16283

Merged
aparajit-pratap merged 1 commit into
masterfrom
aparajit-pratap-patch-4
Jun 9, 2025
Merged

Update build_dynamo_core.yml#16283
aparajit-pratap merged 1 commit into
masterfrom
aparajit-pratap-patch-4

Conversation

@aparajit-pratap

Copy link
Copy Markdown
Contributor

Purpose

Attempt fix for Linux build.

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Attempt fix for Linux build.
Copilot AI review requested due to automatic review settings June 9, 2025 16:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the build workflow for DynamoCore on Linux by replacing the MSBuild command with dotnet build to address Linux build issues.

  • Replaces msbuild with dotnet build for building DynamoCore
  • Adjusts build command parameters for Linux configuration
Comments suppressed due to low confidence (1)

.github/workflows/build_dynamo_core.yml:85

  • The step name 'Build DynamoCore with MSBuild for Linux' is now misleading since the build command uses dotnet build; consider updating the step name to reflect the change.
run: dotnet build ${{ github.workspace }}\Dynamo\src\DynamoCore.sln -c Release /p:Platform=NET_Linux

@aparajit-pratap aparajit-pratap merged commit 3c3382f into master Jun 9, 2025
23 of 25 checks passed
@aparajit-pratap aparajit-pratap deleted the aparajit-pratap-patch-4 branch June 9, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants