DYN-9034: Fix context menu for node customizations

[zeusongit]

Purpose

Fix context menu for node customizations

Declarations

Check these if you believe they are true

• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB
• This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Fix context menu for node customizations

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9034

[Copilot]

Pull Request Overview

This PR addresses DYN-9034 by fixing the context menu behavior for node customizations. Key changes include updating the stashing mechanism for menu items to use MainContextMenu instead of grid.ContextMenu and updating the DisplayNodeContextMenu method to properly clear and configure the active context menu.

Comments suppressed due to low confidence (1)

src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:2369

• [nitpick] It would be beneficial to add a clarifying comment explaining the reasoning behind clearing MainContextMenu.Items and then assigning nodeContextMenu to MainContextMenu, to improve code clarity.

MainContextMenu.Items.Clear();

[aparajit-pratap]

LGTM but I'm still confused about nodeContextMenu and MainContextMenu. Are these two different things? If not, why do we need two separate properties/fields to refer to the same thing?

[zeusongit]

LGTM but I'm still confused about nodeContextMenu and MainContextMenu. Are these two different things? If not, why do we need two separate properties/fields to refer to the same thing?

I had the same question initially, but here’s what I gathered from reviewing the implementation:

I’ve replaced most usages of nodeContextMenu with MainContextMenu, and I think there are two main reasons why both exist:
Avoiding binding errors: When re-adding stashed CustomizationMenuItems to the context menu, using nodeContextMenu helps prevent errors about items already being attached. This seems to be a safeguard against reattachment issues.
Performance and encapsulation: nodeContextMenu is a private static variable where we apply the menu style during initialization. Keeping it separate might help with performance or encapsulation, especially if the style setup is meant to be reused.

[aparajit-pratap]

Too many context menus hanging around. Perhaps they could be named appropriately to denote which is which and what purpose they serve?

[zeusongit]

I added some comments to make it clear,
nodeContextMenu is static and used to handle context menu style,
MainContextMenu and grid.ContextMenu are same, but we have to define MainContextMenu separately as it is used publicly in other classes and tests.