DYN-9050: Improve buttons sizes#16318
Merged
Merged
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9050
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the NodeAutoCompleteBar to use boolean flags for icon states and adjusts button icon sizes for better visual consistency.
- Updated icon dimensions from 16px to 12px/20px and replaced direct source bindings with DataTriggers.
- Removed string source properties in the ViewModel and introduced
HasPrevious/HasNextboolean properties.
Reviewed Changes
Copilot reviewed 2 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml | Resized icons and added Image.Style/DataTriggers for dynamic sources |
| src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs | Removed source strings, added HasPrevious/HasNext properties |
Comments suppressed due to low confidence (2)
src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml:436
- The
x:Name="DotsImage"is used twice in this ControlTemplate, which will cause naming conflicts. Consider giving the close-tab image a distinct name (e.g.,CloseTabImage).
<Image x:Name="DotsImage"
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs:300
- New boolean flags
HasPreviousandHasNextencapsulate navigation logic. Ensure unit tests cover edge cases (e.g.,selectedIndex == 0,selectedIndex == ClusterResultsCount - 1).
public bool HasPrevious => selectedIndex > 0;
johnpierson
approved these changes
Jun 24, 2025
BogdanZavu
approved these changes
Jun 24, 2025
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
Improve buttons sizes to be larger and more visually coherent.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Improve buttons sizes to be larger and more visually coherent.
Reviewers
@johnpierson
@BogdanZavu
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of