Skip to content

DYN-9050: Improve buttons sizes#16318

Merged
johnpierson merged 6 commits into
DynamoDS:masterfrom
chubakueno:feature/DYN-9050
Jun 24, 2025
Merged

DYN-9050: Improve buttons sizes#16318
johnpierson merged 6 commits into
DynamoDS:masterfrom
chubakueno:feature/DYN-9050

Conversation

@chubakueno

@chubakueno chubakueno commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Purpose

Improve buttons sizes to be larger and more visually coherent.

image
image

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Improve buttons sizes to be larger and more visually coherent.

Reviewers

@johnpierson
@BogdanZavu

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@chubakueno chubakueno changed the title Improve buttons sizes DYN-9050: Improve buttons sizes Jun 24, 2025

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9050

@johnpierson johnpierson requested a review from Copilot June 24, 2025 13:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the NodeAutoCompleteBar to use boolean flags for icon states and adjusts button icon sizes for better visual consistency.

  • Updated icon dimensions from 16px to 12px/20px and replaced direct source bindings with DataTriggers.
  • Removed string source properties in the ViewModel and introduced HasPrevious/HasNext boolean properties.

Reviewed Changes

Copilot reviewed 2 out of 9 changed files in this pull request and generated 1 comment.

File Description
src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml Resized icons and added Image.Style/DataTriggers for dynamic sources
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs Removed source strings, added HasPrevious/HasNext properties
Comments suppressed due to low confidence (2)

src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml:436

  • The x:Name="DotsImage" is used twice in this ControlTemplate, which will cause naming conflicts. Consider giving the close-tab image a distinct name (e.g., CloseTabImage).
                                            <Image x:Name="DotsImage"

src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs:300

  • New boolean flags HasPrevious and HasNext encapsulate navigation logic. Ensure unit tests cover edge cases (e.g., selectedIndex == 0, selectedIndex == ClusterResultsCount - 1).
        public bool HasPrevious => selectedIndex > 0;

@johnpierson johnpierson self-requested a review June 24, 2025 13:47

@johnpierson johnpierson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i added a little additional padding to the buttons so misclicks don't happen
image

@BogdanZavu

Copy link
Copy Markdown
Contributor

LGTM!

@johnpierson johnpierson merged commit fa56e79 into DynamoDS:master Jun 24, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants