Skip to content

Some cleanup from PR #16300#16372

Closed
aparajit-pratap wants to merge 1 commit into
DynamoDS:masterfrom
aparajit-pratap:cleanupCBN
Closed

Some cleanup from PR #16300#16372
aparajit-pratap wants to merge 1 commit into
DynamoDS:masterfrom
aparajit-pratap:cleanupCBN

Conversation

@aparajit-pratap

Copy link
Copy Markdown
Contributor

Purpose

Some cleanup from PR #16300

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@aparajit-pratap aparajit-pratap requested review from a team and Copilot July 14, 2025 03:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up leftover tooltip logic and enhances the static type inference in code blocks.

  • Removed the unused GetCleanedCodeExpressionsForTooltips method and all references to outputPortTooltips
  • Updated InferStaticTypeFromNode to classify IdentifierListNode as either a property or function and added a case for LanguageBlockNode
  • Cleaned up the CodeBlockNodeModel by deleting the outputPortTooltips field and related code

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/DynamoCore/Graph/Nodes/CodeBlockUtils.cs Deleted tooltip extraction helper; expanded InferStaticTypeFromNode switch to handle properties and language blocks
src/DynamoCore/Graph/Nodes/CodeBlockNode.cs Removed outputPortTooltips field, its clearing, and assignment
Comments suppressed due to low confidence (3)

src/DynamoCore/Graph/Nodes/CodeBlockUtils.cs:299

  • Add a unit test to verify that IdentifierListNode returns "[property]" when TryGetPropertyName succeeds and "[function]" otherwise to prevent regressions.
                    if(ProtoCore.Utils.CoreUtils.TryGetPropertyName(node.ToString(), out string _))

src/DynamoCore/Graph/Nodes/CodeBlockUtils.cs:306

  • Add a unit test to confirm that LanguageBlockNode is correctly mapped to "[language block]".
                case LanguageBlockNode:

src/DynamoCore/Graph/Nodes/CodeBlockNode.cs:44

  • Since outputPortTooltips and its usage have been removed, ensure that any UI bindings, serialization code, or documentation referring to output port tooltips are updated or cleaned up to avoid stale references.
        private List<string> outputPortNames = new List<string>();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants