Some cleanup from PR #16300#16372
Closed
aparajit-pratap wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up leftover tooltip logic and enhances the static type inference in code blocks.
- Removed the unused
GetCleanedCodeExpressionsForTooltipsmethod and all references tooutputPortTooltips - Updated
InferStaticTypeFromNodeto classifyIdentifierListNodeas either a property or function and added a case forLanguageBlockNode - Cleaned up the
CodeBlockNodeModelby deleting theoutputPortTooltipsfield and related code
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DynamoCore/Graph/Nodes/CodeBlockUtils.cs | Deleted tooltip extraction helper; expanded InferStaticTypeFromNode switch to handle properties and language blocks |
| src/DynamoCore/Graph/Nodes/CodeBlockNode.cs | Removed outputPortTooltips field, its clearing, and assignment |
Comments suppressed due to low confidence (3)
src/DynamoCore/Graph/Nodes/CodeBlockUtils.cs:299
- Add a unit test to verify that
IdentifierListNodereturns "[property]" whenTryGetPropertyNamesucceeds and "[function]" otherwise to prevent regressions.
if(ProtoCore.Utils.CoreUtils.TryGetPropertyName(node.ToString(), out string _))
src/DynamoCore/Graph/Nodes/CodeBlockUtils.cs:306
- Add a unit test to confirm that
LanguageBlockNodeis correctly mapped to "[language block]".
case LanguageBlockNode:
src/DynamoCore/Graph/Nodes/CodeBlockNode.cs:44
- Since
outputPortTooltipsand its usage have been removed, ensure that any UI bindings, serialization code, or documentation referring to output port tooltips are updated or cleaned up to avoid stale references.
private List<string> outputPortNames = new List<string>();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Some cleanup from PR #16300
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of