Skip to content

DYN-9379: Fix connection aborted when panning #16519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubakueno merged 1 commit into from
Sep 25, 2025
Merged

DYN-9379: Fix connection aborted when panning #16519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ private void OnCanvasMouseDown(object sender, MouseButtonEventArgs e)

if(PortContextMenu.IsOpen) DestroyPortContextMenu();

if (!ViewModel.IsPanning && e.MiddleButton == MouseButtonState.Pressed)
if (!ViewModel.IsConnecting && !ViewModel.IsPanning && e.MiddleButton == MouseButtonState.Pressed)
{
ViewModel.RequestTogglePanMode();
}
Expand Down Expand Up @@ -950,7 +950,7 @@ private void OnMouseRelease(object sender, MouseButtonEventArgs e)
ContextMenuPopup.IsOpen = true;
}

if (ViewModel.IsPanning && e.MiddleButton == MouseButtonState.Released)
if (!ViewModel.IsConnecting && ViewModel.IsPanning && e.MiddleButton == MouseButtonState.Released)
{
ViewModel.RequestTogglePanMode();
}
Comment on lines +953 to 956

@aparajit-pratap aparajit-pratap Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how this worked before since this code looks like it was introduced only in 3.6 (seeing the PRs referenced in the description). Was there a call to RequestTogglePanMode elsewhere in the code?

@chubakueno chubakueno Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connecting mode allows for panning, but when you explicity request Panning mode, Panning mode does not allow for connection.

Expand Down
Loading