DYN-9702 templates to home screen#16932
Conversation
- initial changes to the Dynamo backend to consume and show Dynamo Template files on HomePage - created StartPage container for Template files - added backend infrastructure to send Template files data to frontend on load
Add NewWorkspaceWithTemplate method to HomePage that creates a new workspace and inserts a template file, enabling the sidebar to open templates in a new editable workspace.
…m/Chloepeg/Dynamo into DYN-9702-templates-to-home-screen
github-actions
Bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9702
avidit
changed the title
|
How are the file names displayed? Is it just the name of the file now? |
|
@Chloepeg can you rebase this PR from master to get the new Template Filenames for these mockups? |
Yes, for the Homepage, the templates are shown using the filename, so Create a Graph.dyn displays as "Create a Graph", this is automatic from the filename. For the side panel, The names displayed are still template 1 and template 2 but the code matches them to the actual files by filename, I've updated the matching logic to work with the new filenames. DynamoDS/DynamoHome#66 |
- initial changes to the Dynamo backend to consume and show Dynamo Template files on HomePage - created StartPage container for Template files - added backend infrastructure to send Template files data to frontend on load
Add NewWorkspaceWithTemplate method to HomePage that creates a new workspace and inserts a template file, enabling the sidebar to open templates in a new editable workspace.
Add root folder bundle file to embedded resources
…m/Chloepeg/Dynamo into DYN-9702-templates-to-home-screen
Adds the missing TemplateFiles property to StartPageViewModel
Fixes build error
…workspace" This reverts commit e8ecae4.
remove merge conflict marker
|
@Chloepeg, I had a couple of comments about src/DynamoCoreWpf/PublicAPI.Unshipped.txt I think if all are addressed and the failing checks pass, it should be good to go. |
| Dynamo.ViewModels.DynamoViewModel.NewHomeWorkspaceCommand.set -> void | ||
| Dynamo.ViewModels.DynamoViewModel.NodeFromSelectionCommand.get -> Dynamo.UI.Commands.DelegateCommand | ||
| Dynamo.ViewModels.DynamoViewModel.NodeFromSelectionCommand.set -> void | ||
| >>>>>>> e3fb926e0c (initial dynamo changes) |
There was a problem hiding this comment.
Looks like this is a merge conflict that was not 100% resolved?
There was a problem hiding this comment.
I removed stray conflict marker and the duplicate shipped API entries
| @@ -6,6 +6,1606 @@ Dynamo.Controls.OnlineStatusTextConverter | |||
| Dynamo.Controls.OnlineStatusTextConverter.Convert(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object | |||
| Dynamo.Controls.OnlineStatusTextConverter.ConvertBack(object value, System.Type targetType, object parameter, System.Globalization.CultureInfo culture) -> object | |||
| Dynamo.Controls.OnlineStatusTextConverter.OnlineStatusTextConverter() -> void | |||
| Dynamo.Controls.PackageDetailsLinkCollapseOnEmpty | |||
There was a problem hiding this comment.
Are there really 3201 additions to the API? That seems unlikely.
I imagine these were automatically added by some process, which got confused. You may want to back these out and then confirm whether there actually were any additions to the API.
There was a problem hiding this comment.
I’ve matched the file to what’s on the main Dynamo repo and kept only the actual new API from this work (StartPageViewModel.TemplateFiles)
…mpiles Fix DynamoCoreWpf.csproj DynamoHome embed and duplicate compiles
StartPage - Pulled “build one StartPageListItem from a path” into AddTemplateListItemFromPath so LoadTemplates() stays simpler - Made the templateFiles ObservableCollection readonly (only assigned in the constructor). - Renamed the local List<string> to rootDynPaths so it doesn’t shadow the templateFiles field. - Removed “&& this != null” on the non-empty check (always true in an instance method). Homepage - Replaced async void with async Task on LoadGraphs, LoadTemplates, SendSamplesData, SendTemplateData, and SendRecentGraphsData (Sonar S3168). - LoadingDone and RecentFiles_CollectionChanged use _ = Method() where the caller must stay void; SendTemplateData awaits LoadTemplates, SendRecentGraphsData awaits LoadGraphs. - Renamed the local in SendTemplateData to items for clarity.
Remove unused dirPaths in LoadTemplates() (StartPage.xaml.cs).
Use StartsWith('.') instead of StartsWith(".") for extension checks
Replace TODO comment in SendRecentGraphsData() with a neutral comment
|
jasonstratton
left a comment
jasonstratton
left a comment
There was a problem hiding this comment.
Looks good with the updates. Thank you.
This reverts commit 5dbb791.
4 participants
Purpose
This PR addresses DYN-9702 https://jira.autodesk.com/browse/DYN-9702
The changes in the code aim to add backend support for Dynamo template files on the HomePage, enabling templates to be opened in a new editable workspace
Changes :
Declarations
Check these if you believe they are true
Release Notes
Added backend support for for 9702- template-file-support in DynamoHome repo, enabling templates to be opened in a new editable workspace.
Reviewers
@zeusongit
@DynamoDS/eidos
FYIs
@dnenov
@johnpierson