Skip to content

DYN-10274 Add skill - dynamo-unit-testing#16960

Merged
QilongTang merged 7 commits into
DynamoDS:masterfrom
avidit:kca/dyn-10274
Mar 13, 2026
Merged

DYN-10274 Add skill - dynamo-unit-testing#16960
QilongTang merged 7 commits into
DynamoDS:masterfrom
avidit:kca/dyn-10274

Conversation

@avidit

@avidit avidit commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Purpose

Add skill - dynamo-unit-testing

Declarations

Check these if you believe they are true

Release Notes

N/A

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copilot AI review requested due to automatic review settings March 12, 2026 20:44

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10274

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new repository “skill” for writing Dynamo NUnit tests and updates the agent guidance index/pointers so AI tools can discover and follow the new testing patterns.

Changes:

  • Added a new .agents skill: dynamo-unit-testing (skill doc + testing patterns + quality checklist).
  • Introduced a new top-level AGENTS.md guidance entry point and redirected CLAUDE.md.
  • Updated agent documentation to include the new skill and fixed Jira-template link locations.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
CLAUDE.md Replaced detailed Claude guidance with a pointer to AGENTS.md.
AGENTS.md New top-level agent guidance: project context, conventions, and links to .agents skills.
.agents/skills/dynamo-unit-testing/SKILL.md New unit testing skill definition and workflow.
.agents/skills/dynamo-unit-testing/assets/test-patterns.md Added test base-class guidance and example patterns/snippets.
.agents/skills/dynamo-unit-testing/references/quality-checklist.md Added a checklist + anti-patterns reference for test quality.
.agents/skills/dynamo-pr-description/SKILL.md Updated Jira template link to the new assets/template.md location.
.agents/skills/dynamo-jira-ticket/assets/template.md Added a structured Jira ticket template (new location).
.agents/README.md Registered the new skill and updated links/paths for rules/templates.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread .agents/skills/dynamo-unit-testing/test-patterns.md
Comment thread CLAUDE.md
Comment thread .agents/README.md
Comment thread AGENTS.md
Comment thread AGENTS.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@@ -0,0 +1,60 @@
---
name: dynamo-unit-testing
description: Write comprehensive NUnit tests for the Dynamo codebase following Dynamo testing patterns, conventions, and architectural constraints. Use this skill when writing test methods, test classes, setting up test infrastructure, mocking dependencies, testing with .dyn files, or reviewing test code in Dynamo.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the part I dont think nested structure works for Github Copilot agent customization, I had a PR earlier for designer skill went in this way and I had to flat it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I will flatten it out.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sonarqubecloud

Copy link
Copy Markdown

@avidit
avidit requested a review from QilongTang March 13, 2026 14:59
@QilongTang
QilongTang merged commit e501a4b into DynamoDS:master Mar 13, 2026
27 of 30 checks passed
@avidit
avidit deleted the kca/dyn-10274 branch March 13, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants