DYN-10353: Fix wrong AppData version directory for Sandbox#17011
Merged
jasonstratton merged 2 commits intoApr 3, 2026
Conversation
…ost directory check Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10353
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect AppData version folder selection for Dynamo Sandbox when no host directory is configured by adjusting PathManager.TraverseForExecutableAssembly()’s stack-walk behavior (introduced in #16951) so it doesn’t accidentally derive the version from unrelated framework/runtime assemblies.
Changes:
- Adds a guard to only run the “Option 2” managed stack-walk in
TraverseForExecutableAssembly()under certain host-path conditions. - Adds comments explaining why the stack-walk should be avoided for standalone Sandbox scenarios.
|
Use !string.IsNullOrEmpty instead of PathHelper.IsValidPath for the host directory check, since the latter calls File.Exists which returns false for directories. Update XML summary and inline comments to reflect that Option 2 is now conditional. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zeusongit
approved these changes
Apr 3, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> (cherry picked from commit 68b6d2e)
|
Successfully created backport PR for |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-10353. The
TraverseForExecutableAssemblystack walk (introduced in #16951) can pick up .NET runtime assemblies when no host directory is configured, causing Sandbox to create a10.0AppData directory instead of4.1.Declarations
Release Notes
N/A
Reviewers
Copilot
@DynamoDS/eidos
FYIs
No release notes as it is a fix to an earlier PR, which contains the release note