DYN-9998 GraphNodeManager Crash#17054
Merged
Merged
Conversation
Fix Graph Node Manager CSV export crash on empty/new workspaces by adding safe filename fallbacks, empty-data guards in JSON-to-CSV conversion, and a regression test. - GraphNodeManagerView.xaml.cs: Make export default filename safe for unsaved workspaces by falling back to workspace name, then GraphNodes. - Utilities.cs: Harden CSV export for empty data by returning empty output safely and avoiding JSON-to-CSV conversion crashes on empty/null payloads. - GraphNodeManagerViewExtensionTests.cs: Add regression test to verify jsonToCSV handles [] without throwing and returns no rows.
RobertGlobant20
requested review from
QilongTang,
aparajit-pratap,
Copilot and
zeusongit
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9998
Contributor
Author
|
GIF showing that there is no crash now. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Graph Node Manager export crash scenario for new/empty workspaces by making the default export filename safer and hardening JSON-to-CSV conversion against empty inputs, with a regression test.
Changes:
- Add safe fallback logic for the export default filename when the current workspace hasn’t been saved.
- Guard CSV export / JSON-to-CSV conversion to safely return empty output for empty/null payloads.
- Add a regression test verifying
jsonToCSV("[]")returns no rows and doesn’t throw.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/GraphNodeManagerViewExtension/GraphNodeManagerView.xaml.cs | Adds filename fallback logic when workspace filename is unavailable. |
| src/GraphNodeManagerViewExtension/Utilities/Utilities.cs | Adds empty-input/empty-table guards to prevent JSON→CSV conversion crashes and handles empty CSV output. |
| test/DynamoCoreWpf2Tests/ViewExtensions/GraphNodeManagerViewExtensionTests.cs | Adds a regression test for empty-array JSON conversion behavior. |
Prevent Graph Node Manager export crashes on new/empty workspaces by sanitizing default export file names (invalid chars and reserved names) and hardening CSV conversion for empty payloads; add regression tests for empty JSON-to-CSV and filename sanitization behavior.
Removed Assert.DoesNotThrow wrapper from JsonToCsvWithEmptyArrayReturnsNoRows.
Now it directly calls jsonToCSV("[]") and asserts:
Assert.IsNotNull(csvLines)
Assert.IsEmpty(csvLines)
This gives clearer assertion failures if behavior regresses. No file-level errors were reported after the change.
|
QilongTang
approved these changes
Apr 18, 2026
Contributor
Author
|
Dynamo SelfServe passed here: https://c007.cloudbees-ci.autodesk.com/job/DYNCI/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/120/ |
zeusongit
approved these changes
Apr 20, 2026
zeusongit
left a comment
zeusongit
left a comment
Contributor
There was a problem hiding this comment.
LGTM, feel free to merge @RobertGlobant20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix Graph Node Manager CSV export crash on empty/new workspaces by adding safe filename fallbacks, empty-data guards in JSON-to-CSV conversion, and a regression test.
GraphNodeManagerView.xaml.cs: Make export default filename safe for unsaved workspaces by falling back to workspace name, then GraphNodes.
Utilities.cs: Harden CSV export for empty data by returning empty output safely and avoiding JSON-to-CSV conversion crashes on empty/null payloads.
GraphNodeManagerViewExtensionTests.cs: Add regression test to verify jsonToCSV handles [] without throwing and returns no rows.
Declarations
Check these if you believe they are true
Release Notes
Fix Graph Node Manager CSV export crash on empty/new workspaces
Reviewers
@QilongTang @zeusongit @aparajit-pratap
FYIs