DYN-9998 GraphNodeManager Crash

src/GraphNodeManagerViewExtension/GraphNodeManagerView.xaml.cs

@@ -61,7 +61,11 @@ private void ViewModel_RequestExportGraph(object parameter)
         {
             if (parameter == null) return;
             var type = parameter.ToString();
-            var promptName = System.IO.Path.GetFileNameWithoutExtension(viewModel.CurrentWorkspace.FileName);
+            var workspaceFileName = viewModel.CurrentWorkspace?.FileName;
+            var rawPromptName = !string.IsNullOrWhiteSpace(workspaceFileName)
+                ? System.IO.Path.GetFileNameWithoutExtension(workspaceFileName)
+                : viewModel.CurrentWorkspace?.Name;
+            var promptName = SanitizePromptNameForFile(rawPromptName);
 
             var filteredNodes = NodesInfoDataGrid.ItemsSource.Cast<GridNodeViewModel>().ToArray();
 
@@ -76,6 +80,42 @@ private void ViewModel_RequestExportGraph(object parameter)
             }
         }
 
+        private static string SanitizePromptNameForFile(string promptName)
+        {
+            const string fallbackName = "GraphNodes";
+
+            if (string.IsNullOrWhiteSpace(promptName))
+            {
+                return fallbackName;
+            }
+
+            var invalidChars = System.IO.Path.GetInvalidFileNameChars();
+            var sanitized = new string(promptName
+                .Select(ch => invalidChars.Contains(ch) ? '_' : ch)
+                .ToArray())
+                .Trim()
+                .TrimEnd('.');
+
+            if (string.IsNullOrWhiteSpace(sanitized))
+            {
+                return fallbackName;
+            }
+
+            var windowsReservedNames = new[]
+            {
+                "CON", "PRN", "AUX", "NUL",
+                "COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",
+                "LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9",
+            };
+
+            if (windowsReservedNames.Contains(sanitized, StringComparer.OrdinalIgnoreCase))
+            {
+                return fallbackName;
+            }
+
+            return sanitized;
+        }
+
         private void ViewModel_OnPropertyChanged(object? sender, PropertyChangedEventArgs e)
         {
             if (e.PropertyName == nameof(GraphNodeManagerViewModel.IsAnyFilterOn))

src/GraphNodeManagerViewExtension/Utilities/Utilities.cs

@@ -8,6 +8,7 @@
 using Dynamo.Wpf.Utilities;
 using Dynamo.Wpf.Properties;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
 
 namespace Dynamo.GraphNodeManager.Utilities
 {
@@ -48,6 +49,12 @@ public static void ExportToCSV(object exportObject, string promptName)
 
                     var csv = jsonToCSV(output);
 
+                    if (csv.Count == 0)
+                    {
+                        File.WriteAllText(saveFileDialog.FileName, string.Empty);
+                        return;
+                    }
+
                     //write csv file into file stream
                     File.WriteAllLines(saveFileDialog.FileName, csv);
                 }
@@ -95,6 +102,17 @@ public static void ExportToJson(object exportObject, string promptName)
         /// <returns></returns>
         public static List<string> jsonToCSV(string jsonContent)
         {
+            if (string.IsNullOrWhiteSpace(jsonContent))
+            {
+                return new List<string>();
+            }
+
+            var jsonToken = JToken.Parse(jsonContent);
+            if ((jsonToken is JArray jsonArray && !jsonArray.HasValues) || jsonToken.Type == JTokenType.Null)
+            {
+                return new List<string>();
+            }
+
             XmlNode xml = JsonConvert.DeserializeXmlNode("{records:{record:" + jsonContent + "}}");
             XmlDocument xmldoc = new XmlDocument();
 
@@ -104,6 +122,11 @@ public static List<string> jsonToCSV(string jsonContent)
             DataSet dataSet = new DataSet();
 
             dataSet.ReadXml(xmlReader);
+            if (dataSet.Tables.Count == 0)
+            {
+                return new List<string>();
+            }
+
             var dataTable = dataSet.Tables[0];
 
             //Datatable to CSV

test/DynamoCoreWpf2Tests/ViewExtensions/GraphNodeManagerViewExtensionTests.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
+using System.Reflection;
 using System.Windows;
 using System.Windows.Controls;
 using System.Windows.Media;
@@ -235,6 +236,43 @@ public void ContainsEmptyListOrNullTest()
             Assert.AreEqual(nullNodesCount, nullNodesImageCount);
         }
 
+        [Test]
+        public void JsonToCsvWithEmptyArrayReturnsNoRows()
+        {
+            var csvLines = Dynamo.GraphNodeManager.Utilities.Utilities.jsonToCSV("[]");
+
+            Assert.IsNotNull(csvLines);
+            Assert.IsEmpty(csvLines);
+        }
+
+        [Test]
+        public void SanitizePromptNameForFile_ConvertsInvalidCharacters()
+        {
+            var method = typeof(GraphNodeManagerView).GetMethod(
+                "SanitizePromptNameForFile",
+                BindingFlags.NonPublic | BindingFlags.Static);
+
+            Assert.IsNotNull(method);
+
+            var sanitized = method.Invoke(null, new object[] { "Graph:Name*?" }) as string;
+
+            Assert.AreEqual("Graph_Name__", sanitized);
+        }
+
+        [Test]
+        public void SanitizePromptNameForFile_UsesFallbackForReservedNames()
+        {
+            var method = typeof(GraphNodeManagerView).GetMethod(
+                "SanitizePromptNameForFile",
+                BindingFlags.NonPublic | BindingFlags.Static);
+
+            Assert.IsNotNull(method);
+
+            var sanitized = method.Invoke(null, new object[] { "CON" }) as string;
+
+            Assert.AreEqual("GraphNodes", sanitized);
+        }
+
         #region EnablePersistExtensions Tests
         /// <summary>
         /// Test if the Extension loads correctly when remembered