DYN-9976: Fix typo in Sphere.ByCenterPointRadius and TSplineSurface.ByCenterPointRadius node descriptions#17073
Conversation
Agent-Logs-Url: https://github.com/DynamoDS/Dynamo/sessions/cba4b5a6-95aa-4ab3-9f15-c7b61bbe1cb4 Co-authored-by: zeusongit <32665108+zeusongit@users.noreply.github.com>
zeusongit
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9976
There was a problem hiding this comment.
Pull request overview
Fixes a user-visible typo in the English (en-GB) XML documentation for two ProtoGeometry nodes, improving tooltips and the Documentation Browser text.
Changes:
- Corrects “cetered” → “centered” in the
<summary>forSphere.ByCenterPointRadius. - Corrects “cetered” → “centered” in the
<summary>forTSplineSurface.BySphereCenterPointRadius.
|
There was a problem hiding this comment.
This file should not be manually edited in Dynamo. It is created while building protogeometry.dll in the libg repo and is sourced from the libg nuget package, then manually checked in again here. This is sort of a roundabout process and should ideally be rectified. The reason this xml file is being submitted here is because the localization team picks up the file from the Dynamo repo for translation. There is a slack conversation about looking at improving this process and moving the xml localization to the source repo, LibG, in this case.
"cetered" → "centered" in the
<summary>doc for two nodes indoc/distrib/xml/en-GB/ProtoGeometry.xml. Typo was visible in both the node tooltip and the Documentation Browser.doc/distrib/xml/en-GB/ProtoGeometry.xmlSphere.ByCenterPointRadius:"cetered"→"centered"TSplineSurface.ByCenterPointRadius:"cetered"→"centered"