DYN-10440: Fix Microsoft.CodeAnalysis satellite assemblies leaking into pt-BR build output#17082
Merged
jasonstratton merged 2 commits intoApr 29, 2026
Conversation
…ild output Remove `runtime` from IncludeAssets for Microsoft.CodeAnalysis.PublicApiAnalyzers in DynamoCore, DynamoCoreWpf, DynamoUtilities, and DynamoServices. The package is a build-time-only analyzer and needs no runtime artifacts; including `runtime` caused its pt-BR satellite assemblies (Microsoft.CodeAnalysis.resources.dll and Microsoft.CodeAnalysis.CSharp.resources.dll) to be copied into the build output. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes runtime from IncludeAssets for the Microsoft.CodeAnalysis.PublicApiAnalyzers package references so Roslyn analyzer satellite assemblies (e.g., pt-BR/) don’t get copied into Dynamo build output. This aligns the dependency usage with its build-time-only intent across the solution.
Changes:
- Updated
PackageReferenceIncludeAssetsforMicrosoft.CodeAnalysis.PublicApiAnalyzersto excluderuntimein 4 projects. - Keeps
PrivateAssets=allso the analyzer remains non-transitive to downstream consumers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/NodeServices/DynamoServices.csproj | Removes runtime from analyzer IncludeAssets to prevent satellite assemblies in output. |
| src/DynamoUtilities/DynamoUtilities.csproj | Same IncludeAssets adjustment for build-time-only analyzer dependency. |
| src/DynamoCoreWpf/DynamoCoreWpf.csproj | Same IncludeAssets adjustment to avoid copying analyzer runtime artifacts. |
| src/DynamoCore/DynamoCore.csproj | Same IncludeAssets adjustment to prevent pt-BR resource leakage. |
…ild output The LibG package ships Microsoft.CodeAnalysis.CSharp.resources.dll and Microsoft.CodeAnalysis.resources.dll under tools/netstandard2.1/windows/pt-BR/ as unexpected cargo. The BeforeBuildOps wildcard copy (**\*.resources.dll) in DynamoCore.csproj was picking them up and writing them to $(OutputPath)\pt-BR\. Add an Exclude to the LibGProtoGeometryUICultureAllLanguages item to filter out Microsoft.CodeAnalysis*.resources.dll files from the LibG copy, while still copying all legitimate locale resources (ProtoGeometry, LibG.ProtoInterface, etc.). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
aparajit-pratap
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10440
jasonstratton
approved these changes
Apr 28, 2026
jasonstratton
left a comment
jasonstratton
left a comment
Contributor
There was a problem hiding this comment.
Pretty straightforward
Contributor
|
@aparajit-pratap reran SelfServe Merging |
Contributor
|
/cherrypick |
Contributor
|
/cherrypick |
3 tasks
|
Successfully created backport PR for |
aparajit-pratap
deleted the
aparajit/fix-public-api-analyzer-satellite-assembly-leak
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The LibG NuGet package (
DynamoVisualProgramming.LibG_232_0_0) shipsMicrosoft.CodeAnalysis.CSharp.resources.dllandMicrosoft.CodeAnalysis.resources.dllundertools/netstandard2.1/windows/pt-BR/as unexpected cargo alongside its legitimate locale resources (ProtoGeometry.resources.dll,LibG.ProtoInterface.resources.dll, etc.).The
BeforeBuildOpstarget inDynamoCore.csprojcopies all*.resources.dllfiles from that path recursively using**\*.resources.dll, which picks up theMicrosoft.CodeAnalysissatellite assemblies and writes them to$(OutputPath)\pt-BR\. This was first surfaced by Florin while updatingPackageApprovedDllList.txtfor the Dynamo Core 4.1 upgrade in Revit (REVIT-250592).Fix: add an
Excludeto theLibGProtoGeometryUICultureAllLanguagesitem inDynamoCore.csprojto filter outMicrosoft.CodeAnalysis*.resources.dllfiles from that copy, while still copying all legitimate LibG locale resources.Also removes
runtimefromIncludeAssetsforMicrosoft.CodeAnalysis.PublicApiAnalyzersacross all four referencing projects (DynamoCore,DynamoCoreWpf,DynamoUtilities,DynamoServices) as a correctness cleanup — the package has nolib/folder and is a build-time-only analyzer, soruntimewas always a no-op there.Declarations
Check these if you believe they are true
Release Notes
N/A — build/packaging fix only; no user-facing or API changes.
Reviewers
(FILL ME IN)
FYIs
Florin (reported the issue)