[Cherry-pick] DYN-10440: Fix Microsoft.CodeAnalysis satellite assemblies leaking into pt-BR build output#17086
Merged
Merged
Conversation
Merged
3 tasks
|
Contributor
|
Dynamo Smoke Test failed Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #17082 to
RC4.1.1_masterPurpose
The LibG NuGet package (
DynamoVisualProgramming.LibG_232_0_0) shipsMicrosoft.CodeAnalysis.CSharp.resources.dllandMicrosoft.CodeAnalysis.resources.dllundertools/netstandard2.1/windows/pt-BR/as unexpected cargo alongside its legitimate locale resources (ProtoGeometry.resources.dll,LibG.ProtoInterface.resources.dll, etc.).The
BeforeBuildOpstarget inDynamoCore.csprojcopies all*.resources.dllfiles from that path recursively using**\*.resources.dll, which picks up theMicrosoft.CodeAnalysissatellite assemblies and writes them to$(OutputPath)\pt-BR\. This was first surfaced by Florin while updatingPackageApprovedDllList.txtfor the Dynamo Core 4.1 upgrade in Revit (REVIT-250592).Fix: add an
Excludeto theLibGProtoGeometryUICultureAllLanguagesitem inDynamoCore.csprojto filter outMicrosoft.CodeAnalysis*.resources.dllfiles from that copy, while still copying all legitimate LibG locale resources.Also removes
runtimefromIncludeAssetsforMicrosoft.CodeAnalysis.PublicApiAnalyzersacross all four referencing projects (DynamoCore,DynamoCoreWpf,DynamoUtilities,DynamoServices) as a correctness cleanup — the package has nolib/folder and is a build-time-only analyzer, soruntimewas always a no-op there.Declarations
Check these if you believe they are true
Release Notes
N/A — build/packaging fix only; no user-facing or API changes.
Reviewers
(FILL ME IN)
FYIs
Florin (reported the issue)