10011: DYN-10462: bump up pythonnet3 version#17092
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10011
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Dynamo's direct references to the DynamoVisualProgramming.PythonEngine.PythonNet3 NuGet package from 1.4.7 to 1.4.8, aligning the core build, the migration view extension, and the Python test project on the same engine version.
Changes:
- Bumps the PythonNet3 package version in
DynamoCore, which is the source of the built-in PythonNet3 engine package output. - Bumps the same package in
PythonMigrationViewExtensionso migration UI code compiles against the updated engine assembly. - Bumps the package in
DynamoPythonTestsso Python-focused tests target the same engine version as production code.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/DynamoCore/DynamoCore.csproj |
Updates the core package reference used to build/package the built-in PythonNet3 engine. |
src/PythonMigrationViewExtension/PythonMigrationViewExtension.csproj |
Updates the migration extension's compile-time dependency to the same PythonNet3 version. |
test/Libraries/DynamoPythonTests/DynamoPythonTests.csproj |
Updates the Python test project dependency to keep test/runtime alignment with the engine bump. |
aparajit-pratap
changed the title
github-actions
Bot
changed the title
|
aparajit-pratap
changed the title
github-actions
Bot
changed the title
aparajit-pratap
changed the title
github-actions
Bot
changed the title
Contributor
|
/cherrypick |
3 tasks
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Cherry-pick the fix for DYN-10011 - PythonNet3 1.4.8 update into master. This was updated in the RC branch for 4.0.2 but was missed from being merged into master at that time, which was later released as RC4.1.0. As a result the fix was missing from the RC 4.1 release :(
Declarations
Check these if you believe they are true
Release Notes
Fixed an issue with the engine returns interface type instead of concrete type for IDisposable objects.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of