DYN-7587 : Clicking No still installs a conflicting package

[ivaylo-matov]

Purpose

This PR addresses DYN-7587.

It fixes the case where installing a package that conflicts on custom node (.dyf) GUIDs with an already installed package showed Cannot Download Package, but if the user chose No, the new package could already be copied into Dynamo’s packages folder.

Changes:

• Staged install:
  Custom-node conflicts are checked against already loaded package nodes before anything is copied from the temporary zip into the real packages directory.
• User chooses No:
  Install is cancelled - no copy into the packages folder, staging is removed, and the existing package is not marked for uninstall. Download UI shows a short, specific message (Installation cancelled due to custom node conflict).
• User chooses Yes:
  The existing package is marked for uninstall on next startup and the new package is committed to disk. The download handle shows text that installed files are present but a restart is required (Restart Dynamo to remove the conflicting package) so the old package can be removed.
• Tests
  Package manager / loader tests cover decline (no commit, staging removed, uninstall list unchanged) and accept (commit, staging removed, existing package scheduled for uninstall).

Declarations

Check these if you believe they are true

• Is documented according to the standards
• The level of testing this PR includes is appropriate
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Release Notes

Fixes the case where installing a package that conflicts on custom node (.dyf) GUIDs with an already installed package showed Cannot Download Package, but if the user chose No, the new package could already be copied into Dynamo’s packages folder.

Reviewers

@DynamoDS/eidos
@jasonstratton
@zeusongit

FYIs

@dnenov
@johnpierson

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7587

[Copilot]

Pull request overview

This PR fixes a package-install edge case where a custom-node (.dyf) GUID conflict could still result in files being copied into the user’s packages folder even after the user chose No in the conflict dialog. It does so by introducing a staged install flow (unzip/inspect first, copy/commit only after user confirmation) and adds UI messaging and tests around accept/decline behavior.

Changes:

• Add a staging-based installation workflow in PackageDownloadHandle and update package install flow to pre-check custom node conflicts before committing files.
• Update conflicting-custom-node handling to return a user decision (Yes/No) and show more specific status messaging.
• Add tests intended to cover “decline” (no commit) and “accept” (commit + uninstall-on-restart) paths.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/Libraries/PackageManagerTests/PackageLoaderTests.cs	Adds tests for staged install conflict accept/decline scenarios.
src/DynamoPackages/PackageLoader.cs	Changes conflict event to return a bool decision and adds a public notification method.
src/DynamoPackages/PackageDownloadHandle.cs	Introduces staging APIs (TryPrepareInstallation, CompleteInstallation, DiscardStagingDirectory) and refactors Extract to use them.
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs	Updates conflict handler to return a bool and only mark uninstall when user accepts.
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs	Updates installation flow to pre-check staged custom-node conflicts and commit only on acceptance.
src/DynamoCoreWpf/Properties/Resources.resx	Adds new user-facing strings for install-cancel and restart-required messages.
src/DynamoCoreWpf/Properties/Resources.en-US.resx	Adds en-US entries for the new user-facing strings.
src/DynamoCoreWpf/Properties/Resources.Designer.cs	Regenerates resource designer accessors for the new strings.
src/DynamoCore/Core/CustomNodeManager.cs	Adds an internal helper to detect conflicting package custom nodes by GUID before loading/committing.

Files not reviewed (1)

• src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jasonstratton]

This looks good to me.

@zeusongit , it could not hurt for you to take a quick sanity check. Thanks.

[jasonstratton]

@ivaylo-matov , rather than waiting any longer for an additional review, I have merged the code. Please let me know how it goes. We'll speak at the checkin.